0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-11-24 13:22:45 +01:00
gitea/modules/lfs
Giteabot 6203ae764a
Distinguish LFS object errors to ignore missing objects during migration (#31702) (#31745)
Backport #31702 by @wolfogre

Fix #31137.

Replace #31623 #31697.

When migrating LFS objects, if there's any object that failed (like some
objects are losted, which is not really critical), Gitea will stop
migrating LFS immediately but treat the migration as successful.

This PR checks the error according to the [LFS api
doc](https://github.com/git-lfs/git-lfs/blob/main/docs/api/batch.md#successful-responses).

> LFS object error codes should match HTTP status codes where possible:
> 
> - 404 - The object does not exist on the server.
> - 409 - The specified hash algorithm disagrees with the server's
acceptable options.
> - 410 - The object was removed by the owner.
> - 422 - Validation error.

If the error is `404`, it's safe to ignore it and continue migration.
Otherwise, stop the migration and mark it as failed to ensure data
integrity of LFS objects.

And maybe we should also ignore others errors (maybe `410`? I'm not sure
what's the difference between "does not exist" and "removed by the
owner".), we can add it later when some users report that they have
failed to migrate LFS because of an error which should be ignored.

Co-authored-by: Jason Song <i@wolfogre.com>
2024-07-31 23:06:37 +08:00
..
client.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
client_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
content_store.go Use crypto/sha256 (#29386) 2024-02-25 13:32:13 +00:00
endpoint.go escape filename when assemble URL (#22850) 2023-02-12 09:31:14 +08:00
endpoint_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
filesystem_client.go fix: close file in the Upload func (#30262) 2024-04-03 10:58:13 -04:00
http_client.go Distinguish LFS object errors to ignore missing objects during migration (#31702) (#31745) 2024-07-31 23:06:37 +08:00
http_client_test.go Fix #31185 try fix lfs download from bitbucket failed (#31201) (#31329) 2024-06-12 02:34:37 +03:00
LICENSE Git LFS support v2 (#122) 2016-12-26 09:16:37 +08:00
pointer.go Use crypto/sha256 (#29386) 2024-02-25 13:32:13 +00:00
pointer_scanner_gogit.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
pointer_scanner_nogogit.go Make sure git version&feature are always prepared (#30877) (#30879) 2024-05-07 02:07:33 +00:00
pointer_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
shared.go Distinguish LFS object errors to ignore missing objects during migration (#31702) (#31745) 2024-07-31 23:06:37 +08:00
transferadapter.go Fix #31185 try fix lfs download from bitbucket failed (#31201) (#31329) 2024-06-12 02:34:37 +03:00
transferadapter_test.go Fix #31185 try fix lfs download from bitbucket failed (#31201) (#31329) 2024-06-12 02:34:37 +03:00