0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-12-26 08:44:16 +01:00
gitea/templates
Giteabot b8e6cffd31
Preserve BOM in web editor (#28935) (#28959)
Backport #28935 by @silverwind

The `ToUTF8*` functions were stripping BOM, while BOM is actually valid
in UTF8, so the stripping must be optional depending on use case. This
does:

- Add a options struct to all `ToUTF8*` functions, that by default will
strip BOM to preserve existing behaviour
- Remove `ToUTF8` function, it was dead code
- Rename `ToUTF8WithErr` to `ToUTF8`
- Preserve BOM in Monaco Editor
- Remove a unnecessary newline in the textarea value. Browsers did
ignore it, it seems but it's better not to rely on this behaviour.

Fixes: https://github.com/go-gitea/gitea/issues/28743
Related: https://github.com/go-gitea/gitea/issues/6716 which seems to
have once introduced a mechanism that strips and re-adds the BOM, but
from what I can tell, this mechanism was removed at some point after
that PR.

Co-authored-by: silverwind <me@silverwind.io>
2024-01-27 23:23:31 +01:00
..
admin
api/packages/pypi
base Avoid unnecessary 500 panic when a commit doesn't exist (#28719) (#28721) 2024-01-07 10:40:30 +00:00
code
custom
devtest
explore
mail
org Fix button size in "attached header right" (#28770) (#28774) 2024-01-12 15:04:19 +00:00
package
projects
repo Preserve BOM in web editor (#28935) (#28959) 2024-01-27 23:23:31 +01:00
shared
status
swagger Forbid removing the last admin user (#28337) (#28793) 2024-01-16 01:51:46 +00:00
user Rework markup link rendering (#26745) (#28803) 2024-01-16 02:13:29 +00:00
webhook
home.tmpl
install.tmpl
post-install.tmpl