mirror of
https://github.com/go-gitea/gitea
synced 2024-12-27 09:14:15 +01:00
bb0ff77e46
The recovery, API, Web and package frameworks all create their own HTML Renderers. This increases the memory requirements of Gitea unnecessarily with duplicate templates being kept in memory. Further the reloading framework in dev mode for these involves locking and recompiling all of the templates on each load. This will potentially hide concurrency issues and it is inefficient. This PR stores the templates renderer in the context and stores this context in the NormalRoutes, it then creates a fsnotify.Watcher framework to watch files. The watching framework is then extended to the mailer templates which were previously not being reloaded in dev. Then the locales are simplified to a similar structure. Fix #20210 Fix #20211 Fix #20217 Signed-off-by: Andrew Thornton <art27@cantab.net>
52 lines
1.5 KiB
Go
52 lines
1.5 KiB
Go
// Copyright 2022 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package templates
|
|
|
|
import (
|
|
"context"
|
|
|
|
"code.gitea.io/gitea/modules/log"
|
|
"code.gitea.io/gitea/modules/setting"
|
|
"code.gitea.io/gitea/modules/watcher"
|
|
|
|
"github.com/unrolled/render"
|
|
)
|
|
|
|
var rendererKey interface{} = "templatesHtmlRendereer"
|
|
|
|
// HTMLRenderer returns the current html renderer for the context or creates and stores one within the context for future use
|
|
func HTMLRenderer(ctx context.Context) (context.Context, *render.Render) {
|
|
rendererInterface := ctx.Value(rendererKey)
|
|
if rendererInterface != nil {
|
|
renderer, ok := rendererInterface.(*render.Render)
|
|
if ok {
|
|
return ctx, renderer
|
|
}
|
|
}
|
|
|
|
rendererType := "static"
|
|
if !setting.IsProd {
|
|
rendererType = "auto-reloading"
|
|
}
|
|
log.Log(1, log.DEBUG, "Creating "+rendererType+" HTML Renderer")
|
|
|
|
renderer := render.New(render.Options{
|
|
Extensions: []string{".tmpl"},
|
|
Directory: "templates",
|
|
Funcs: NewFuncMap(),
|
|
Asset: GetAsset,
|
|
AssetNames: GetTemplateAssetNames,
|
|
UseMutexLock: !setting.IsProd,
|
|
IsDevelopment: false,
|
|
DisableHTTPErrorRendering: true,
|
|
})
|
|
if !setting.IsProd {
|
|
watcher.CreateWatcher(ctx, "HTML Templates", &watcher.CreateWatcherOpts{
|
|
PathsCallback: walkTemplateFiles,
|
|
BetweenCallback: renderer.CompileTemplates,
|
|
})
|
|
}
|
|
return context.WithValue(ctx, rendererKey, renderer), renderer
|
|
}
|