mirror of
https://github.com/go-gitea/gitea
synced 2024-11-05 21:59:20 +01:00
81fe5d6185
This improves a lot of accessibility shortcomings. Every possible instance of `<div class="button">` matching the command `ag '<[^ab].*?class=.*?[" ]button[ "]' templates/ | grep -v 'dropdown'` has been converted when possible. divs with the `dropdown` class and their children were omitted as 1. more analysis must be conducted whether the dropdowns still work as intended when they are a `button` instead of a `div`. 2. most dropdowns have `div`s as children. The HTML standard disallows `div`s inside `button`s. 3. When a dropdown child that's part of the displayed text content is converted to a `button`, the dropdown can be focused twice Further changes include that all "gitea-managed" buttons with JS code received an `e.preventDefault()` so that they don't accidentally submit an underlying form, which would execute instead of cancel the action. Lastly, some minor issues were fixed as well during the refactoring. ## Future improvements As mentioned in https://github.com/go-gitea/gitea/pull/23337#discussion_r1127277391, `<a>`s without `href` attribute are not focusable. They should later on be converted to `<button>`s. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
105 lines
4.4 KiB
Handlebars
105 lines
4.4 KiB
Handlebars
{{template "base/head" .}}
|
|
<div role="main" aria-label="{{.Title}}" class="page-content admin user">
|
|
{{template "admin/navbar" .}}
|
|
<div class="ui container">
|
|
{{template "base/alert" .}}
|
|
<h4 class="ui top attached header">
|
|
{{.locale.Tr "admin.emails.email_manage_panel"}} ({{.locale.Tr "admin.total" .Total}})
|
|
</h4>
|
|
<div class="ui attached segment">
|
|
<div class="ui right floated secondary filter menu">
|
|
<!-- Sort -->
|
|
<div class="ui dropdown type jump item">
|
|
<span class="text">
|
|
{{.locale.Tr "repo.issues.filter_sort"}}
|
|
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
|
|
</span>
|
|
<div class="menu">
|
|
<a class="{{if or (eq .SortType "email") (not .SortType)}}active {{end}}item" href="{{$.Link}}?sort=email&q={{$.Keyword}}">{{.locale.Tr "admin.emails.filter_sort.email"}}</a>
|
|
<a class="{{if eq .SortType "reverseemail"}}active {{end}}item" href="{{$.Link}}?sort=reverseemail&q={{$.Keyword}}">{{.locale.Tr "admin.emails.filter_sort.email_reverse"}}</a>
|
|
<a class="{{if eq .SortType "username"}}active {{end}}item" href="{{$.Link}}?sort=username&q={{$.Keyword}}">{{.locale.Tr "admin.emails.filter_sort.name"}}</a>
|
|
<a class="{{if eq .SortType "reverseusername"}}active {{end}}item" href="{{$.Link}}?sort=reverseusername&q={{$.Keyword}}">{{.locale.Tr "admin.emails.filter_sort.name_reverse"}}</a>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
<form class="ui form ignore-dirty" style="max-width: 90%">
|
|
<div class="ui fluid action input">
|
|
<input name="q" value="{{.Keyword}}" placeholder="{{.locale.Tr "explore.search"}}..." autofocus>
|
|
<button class="ui primary button">{{.locale.Tr "explore.search"}}</button>
|
|
</div>
|
|
</form>
|
|
</div>
|
|
<div class="ui attached table segment">
|
|
<table class="ui very basic striped table unstackable">
|
|
<thead>
|
|
<tr>
|
|
<th data-sortt-asc="username" data-sortt-desc="reverseusername">
|
|
{{.locale.Tr "admin.users.name"}}
|
|
{{SortArrow "username" "reverseusername" $.SortType false}}
|
|
</th>
|
|
<th>{{.locale.Tr "admin.users.full_name"}}</th>
|
|
<th data-sortt-asc="email" data-sortt-desc="reverseemail" data-sortt-default="true">
|
|
{{.locale.Tr "email"}}
|
|
{{SortArrow "email" "reverseemail" $.SortType true}}
|
|
</th>
|
|
<th>{{.locale.Tr "admin.emails.primary"}}</th>
|
|
<th>{{.locale.Tr "admin.emails.activated"}}</th>
|
|
</tr>
|
|
</thead>
|
|
<tbody>
|
|
{{range .Emails}}
|
|
<tr>
|
|
<td><a href="{{AppSubUrl}}/{{.Name | PathEscape}}">{{.Name}}</a></td>
|
|
<td><span class="text truncate">{{.FullName}}</span></td>
|
|
<td><span class="text email">{{.Email}}</span></td>
|
|
<td>{{if .IsPrimary}}{{svg "octicon-check"}}{{else}}{{svg "octicon-x"}}{{end}}</td>
|
|
<td>
|
|
{{if .CanChange}}
|
|
<a class="link-email-action" href data-uid="{{.UID}}"
|
|
data-email="{{.Email}}"
|
|
data-primary="{{if .IsPrimary}}1{{else}}0{{end}}"
|
|
data-activate="{{if .IsActivated}}0{{else}}1{{end}}">
|
|
{{if .IsActivated}}{{svg "octicon-check"}}{{else}}{{svg "octicon-x"}}{{end}}
|
|
</a>
|
|
{{else}}
|
|
{{if .IsActivated}}{{svg "octicon-check"}}{{else}}{{svg "octicon-x"}}{{end}}
|
|
{{end}}
|
|
</td>
|
|
</tr>
|
|
{{end}}
|
|
</tbody>
|
|
</table>
|
|
</div>
|
|
|
|
{{template "base/paginate" .}}
|
|
|
|
<div class="ui basic modal" id="change-email-modal">
|
|
<div class="ui icon header">
|
|
{{.locale.Tr "admin.emails.change_email_header"}}
|
|
</div>
|
|
<div class="content center">
|
|
<p class="center">{{.locale.Tr "admin.emails.change_email_text"}}</p>
|
|
|
|
<form class="ui form" id="email-action-form" action="{{AppSubUrl}}/admin/emails/activate" method="post">
|
|
{{$.CsrfTokenHtml}}
|
|
|
|
<input type="hidden" id="query-sort" name="sort" value="{{.SortType}}">
|
|
<input type="hidden" id="query-keyword" name="q" value="{{.Keyword}}">
|
|
<input type="hidden" id="query-primary" name="is_primary" value="{{.IsPrimary}}" required>
|
|
<input type="hidden" id="query-activated" name="is_activated" value="{{.IsActivated}}" required>
|
|
|
|
<input type="hidden" id="form-uid" name="uid" value="" required>
|
|
<input type="hidden" id="form-email" name="email" value="" required>
|
|
<input type="hidden" id="form-primary" name="primary" value="" required>
|
|
<input type="hidden" id="form-activate" name="activate" value="" required>
|
|
|
|
<div class="center">
|
|
{{template "base/delete_modal_actions" .}}
|
|
</div>
|
|
</form>
|
|
</div>
|
|
</div>
|
|
|
|
</div>
|
|
</div>
|
|
{{template "base/footer" .}}
|