0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-12-26 22:04:34 +01:00
gitea/models
zeripath d01763ee14
Protect against NPEs in notifications list (#10879)
Unfortunately there appears to be potential race with notifications
being set before the associated issue has been committed.

This PR adds protection in to the notifications list to log any failures
and remove these notifications from the display.

References #10815 - and prevents the panic but does not completely fix
this.

Signed-off-by: Andrew Thornton <art27@cantab.net>
2020-03-29 20:51:14 +01:00
..
fixtures Fix "access" fixtures and tests (#10247) 2020-02-15 12:29:06 +08:00
migrations make avatar lookup occur at image request (#10540) 2020-03-27 14:34:39 +02:00
access.go Upgrade xorm to v1.0.0 (#10646) 2020-03-22 11:12:55 -04:00
access_test.go Fix "access" fixtures and tests (#10247) 2020-02-15 12:29:06 +08:00
action.go Fix potential bugs (#10513) 2020-02-27 20:10:27 -03:00
action_list.go refactor: reduce sql query in retrieveFeeds (#3547) 2018-02-21 18:55:34 +08:00
action_test.go Restricted users (#6274) 2020-01-13 18:33:46 +01:00
admin.go Use gitea forked macaron (#7933) 2019-08-23 12:40:29 -04:00
admin_test.go
attachment.go Fix potential bugs (#10513) 2020-02-27 20:10:27 -03:00
attachment_test.go Reading pull attachments should depend on read UnitTypePullRequests (#10346) 2020-02-18 21:36:19 -03:00
avatar.go make avatar lookup occur at image request (#10540) 2020-03-27 14:34:39 +02:00
branches.go Allow to set protected file patterns that can not be changed under no conditions (#10806) 2020-03-27 00:26:34 +02:00
branches_test.go
commit_status.go
commit_status_test.go Fix wrong hint when status checking is running on pull request view (#9886) 2020-01-22 11:46:04 +08:00
consistency.go
context.go Refactor repository check and sync functions (#9854) 2020-01-20 20:01:19 +00:00
convert.go
error.go Handle push rejection in branch and upload (#10854) 2020-03-28 01:13:18 -03:00
error_oauth2.go
external_login_user.go
fixture_generation.go Move fixture generation to contrib and add test (#10277) 2020-02-15 10:59:43 +02:00
fixture_test.go Move fixture generation to contrib and add test (#10277) 2020-02-15 10:59:43 +02:00
gpg_key.go Show Signer in commit lists and add basic trust (#10425) 2020-02-27 16:20:55 -03:00
gpg_key_test.go
helper.go Add reactions to issues/PR and comments (#2856) 2017-12-04 01:14:26 +02:00
helper_directory.go
helper_environment.go Move PushUpdateAddDeleteTags to repository module from models (#10106) 2020-02-03 09:47:04 +01:00
issue.go issue search on my related repositories (#9758) 2020-02-29 03:52:05 -03:00
issue_assignees.go Remove Unused Functions (#10516) 2020-03-02 00:05:44 +02:00
issue_assignees_test.go
issue_comment.go Fix potential bugs (#10513) 2020-02-27 20:10:27 -03:00
issue_comment_list.go
issue_comment_test.go
issue_dependency.go
issue_dependency_test.go
issue_label.go [Refactor] move APIFormat() of Issue and Label to convert package (#10423) 2020-02-28 23:49:50 -03:00
issue_label_test.go [Refactor] move APIFormat() of Issue and Label to convert package (#10423) 2020-02-28 23:49:50 -03:00
issue_list.go Add Approval Counts to pulls list (#10238) 2020-03-06 03:44:06 +00:00
issue_list_test.go
issue_lock.go
issue_milestone.go Fix milestone API state parameter unhandled (#10049) 2020-01-29 08:36:32 +02:00
issue_milestone_test.go Fix milestone API state parameter unhandled (#10049) 2020-01-29 08:36:32 +02:00
issue_reaction.go
issue_reaction_test.go
issue_stopwatch.go
issue_stopwatch_test.go
issue_test.go issue search on my related repositories (#9758) 2020-02-29 03:52:05 -03:00
issue_tracked_time.go
issue_tracked_time_test.go
issue_user.go Mail assignee when issue/pull request is assigned (#8546) 2019-10-25 22:46:37 +08:00
issue_user_test.go
issue_watch.go [BugFix] Avoid mailing explicit unwatched (#10475) 2020-02-27 10:07:05 +00:00
issue_watch_test.go
issue_xref.go
issue_xref_test.go Refactor comment (#9330) 2019-12-15 16:57:34 -05:00
lfs.go
lfs_lock.go
list_options.go Upgrade xorm to v1.0.0 (#10646) 2020-03-22 11:12:55 -04:00
log.go Upgrade xorm to v1.0.0 (#10646) 2020-03-22 11:12:55 -04:00
login_source.go Upgrade xorm to v1.0.0 (#10646) 2020-03-22 11:12:55 -04:00
main_test.go
migrate.go Fix migration information update bug when linked github account (#10310) 2020-02-17 19:42:13 -05:00
models.go Fix typo of MSSQL (#10850) 2020-03-27 16:12:39 +02:00
models_test.go
notification.go Protect against NPEs in notifications list (#10879) 2020-03-29 20:51:14 +01:00
notification_test.go
oauth2.go OAuth2: add Yandex provider (#8335) (#10564) 2020-03-05 00:08:52 +02:00
oauth2_application.go adds API endpoints to manage OAuth2 Application (list/create/delete) (#10437) 2020-02-29 03:19:32 -03:00
oauth2_application_test.go
org.go Ensure DeleteUser is not allowed to Delete Orgs and visa versa (#10134) 2020-02-04 16:27:18 +02:00
org_team.go Upgrade xorm to v1.0.0 (#10646) 2020-03-22 11:12:55 -04:00
org_team_test.go
org_test.go Ensure DeleteUser is not allowed to Delete Orgs and visa versa (#10134) 2020-02-04 16:27:18 +02:00
pull.go Add Approval Counts to pulls list (#10238) 2020-03-06 03:44:06 +00:00
pull_list.go
pull_sign.go Display pull request head branch even the branch deleted or repository deleted (#10413) 2020-03-02 22:31:55 +00:00
pull_test.go Display pull request head branch even the branch deleted or repository deleted (#10413) 2020-03-02 22:31:55 +00:00
release.go Move PushUpdateAddDeleteTags to repository module from models (#10106) 2020-02-03 09:47:04 +01:00
repo.go Option to set default branch at repository creation (#10803) 2020-03-26 19:14:51 +00:00
repo_activity.go
repo_branch.go
repo_collaboration.go Show Signer in commit lists and add basic trust (#10425) 2020-02-27 16:20:55 -03:00
repo_collaboration_test.go
repo_generate.go
repo_generate_test.go
repo_indexer.go Index code and stats only for non-empty repositories (#10251) 2020-02-14 13:42:30 +01:00
repo_issue.go
repo_language_stats.go Index code and stats only for non-empty repositories (#10251) 2020-02-14 13:42:30 +01:00
repo_list.go Slight simplification of accessibleRepositoryCondition (#10875) 2020-03-29 15:31:10 +01:00
repo_list_test.go
repo_mirror.go
repo_permission.go
repo_permission_test.go
repo_redirect.go
repo_redirect_test.go
repo_sign.go Sign: Handle ErrTwoFactorNotEnrolled correctly (#10008) 2020-01-26 23:44:12 +00:00
repo_test.go
repo_unit.go Upgrade xorm to v1.0.0 (#10646) 2020-03-22 11:12:55 -04:00
repo_watch.go Code Refactor of IssueWatch related things (#10401) 2020-02-26 03:32:22 -03:00
repo_watch_test.go
review.go
review_test.go
ssh_key.go Use ErrKeyUnableToVerify if fail to calc fingerprint in ssh-keygen (#10863) 2020-03-28 19:24:55 +02:00
ssh_key_test.go
star.go
star_test.go
task.go
test_fixtures.go Upgrade xorm to v1.0.0 (#10646) 2020-03-22 11:12:55 -04:00
token.go FIX Pagination of ListAccessTokens and GetIssueWatchers (#10449) 2020-02-24 16:50:32 -06:00
token_test.go
topic.go Update topics repo count when deleting repository (#10051) 2020-01-31 08:57:19 +02:00
topic_test.go
twofactor.go
u2f.go
u2f_test.go
unit.go
unit_tests.go Upgrade xorm to v1.0.0 (#10646) 2020-03-22 11:12:55 -04:00
update.go Remove Unused Functions (#10516) 2020-03-02 00:05:44 +02:00
upload.go
user.go Add restricted user filter to LDAP authentication (#10600) 2020-03-05 08:30:33 +02:00
user_follow.go
user_follow_test.go
user_heatmap.go
user_heatmap_test.go
user_mail.go Admin page for managing user e-mail activation (#10557) 2020-03-02 15:25:36 -03:00
user_mail_test.go Admin page for managing user e-mail activation (#10557) 2020-03-02 15:25:36 -03:00
user_openid.go
user_openid_test.go
user_test.go Ensure DeleteUser is not allowed to Delete Orgs and visa versa (#10134) 2020-02-04 16:27:18 +02:00
userlist.go
userlist_test.go
webhook.go Add Matrix webhook (#10831) 2020-03-28 15:09:55 +02:00
webhook_test.go Granular webhook events (#9626) 2020-03-06 07:10:48 +02:00
wiki.go
wiki_test.go