0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-11-22 15:23:02 +01:00
gitea/integrations
mrsdizzie ca46385637 Clean up various use of escape/unescape functions for URL generation (#6334)
* Use PathUnescape instead of QueryUnescape when working with branch names

Currently branch names with a '+' fail in certain situations because
QueryUnescape replaces the + character with a blank space.

Using PathUnescape should be better since it is defined as:

// PathUnescape is identical to QueryUnescape except that it does not
// unescape '+' to ' ' (space).

Fixes #6333

* Change error to match new function name

* Add new util function PathEscapeSegments

This function simply runs PathEscape on each segment of a path without
touching the forward slash itself. We want to use this instead of
PathEscape/QueryEscape in most cases because a forward slash is a valid name for a
branch etc... and we don't want that escaped in a URL.

Putting this in new file url.go and also moving a couple similar
functions into that file as well.

* Use EscapePathSegments where appropriate

Replace various uses of EscapePath/EscapeQuery with new
EscapePathSegments. Also remove uncessary uses of various
escape/unescape functions when the text had already been escaped or was
not escaped.

* Reformat comment to make drone build happy

* Remove no longer used url library

* Requested code changes
2019-03-18 10:00:23 -04:00
..
gitea-repositories-meta Fix serving of raw wiki files other than .md (#5814) 2019-02-05 20:58:55 -05:00
migration-test
api_admin_test.go
api_branch_test.go
api_comment_test.go
api_fork_test.go
api_gpg_keys_test.go
api_helper_for_declarative_test.go Fix ssh deploy and user key constraints (#1357) (#5939) 2019-02-03 23:56:53 +00:00
api_issue_label_test.go
api_issue_test.go
api_keys_test.go
api_org_test.go
api_pull_test.go
api_releases_test.go
api_repo_git_commits_test.go Add single commit API support (#5843) 2019-02-02 22:35:17 -05:00
api_repo_git_ref_test.go
api_repo_lfs_locks_test.go
api_repo_raw_test.go
api_repo_tags_test.go Add API to list tags (#5850) 2019-02-07 12:00:52 +00:00
api_repo_test.go Return 409 when creating repo if it already exists. (#6330) 2019-03-15 10:19:09 -04:00
api_team_test.go
api_token_test.go
api_user_heatmap_test.go
api_user_orgs_test.go
auth_ldap_test.go
benchmarks_test.go
branches_test.go
change_default_branch_test.go
delete_user_test.go
download_test.go Allow markdown files to read from the LFS (#5787) 2019-02-12 15:09:43 +00:00
editor_test.go
empty_repo_test.go
explore_repos_test.go
git_helper_for_declarative_test.go use native golang SSH library but ssh-keygen when enable built-in SSH server to remove dependent on that command lines (#5976) 2019-02-07 02:13:12 -05:00
git_test.go Allow markdown files to read from the LFS (#5787) 2019-02-12 15:09:43 +00:00
html_helper.go
integration_test.go Allow markdown files to read from the LFS (#5787) 2019-02-12 15:09:43 +00:00
internal_test.go Clean up various use of escape/unescape functions for URL generation (#6334) 2019-03-18 10:00:23 -04:00
issue_test.go
lfs_getobject_test.go
links_test.go
mssql.ini.tmpl
mysql.ini.tmpl
mysql8.ini.tmpl Add test environment for Mysql8 (#5234) 2019-03-17 15:17:18 -04:00
nonascii_branches_test.go
oauth_test.go Add support for client basic auth for exchanging access tokens (#6293) 2019-03-11 10:54:59 +08:00
pgsql.ini.tmpl
pull_compare_test.go
pull_create_test.go Minor UI tweaks (#5980) 2019-02-19 18:09:47 -05:00
pull_merge_test.go
README.md
README_ZH.md
release_test.go Fix prohibit login check on authorization (#6106) 2019-02-19 09:19:28 +02:00
repo_activity_test.go
repo_branch_test.go
repo_commits_test.go
repo_fork_test.go
repo_migrate_test.go
repo_search_test.go
repo_test.go Fix prohibit login check on authorization (#6106) 2019-02-19 09:19:28 +02:00
setting_test.go Show email if the authenticated user owns the profile page being requested for (#4981) 2019-02-19 09:11:50 -05:00
signin_test.go
signout_test.go
signup_test.go
sqlite.ini
ssh_key_test.go Fix ssh deploy and user key constraints (#1357) (#5939) 2019-02-03 23:56:53 +00:00
timetracking_test.go
user_test.go
version_test.go
xss_test.go

Integrations tests

Integration tests can be run with make commands for the appropriate backends, namely:

make test-mysql
make test-pgsql
make test-sqlite

Make sure to perform a clean build before running tests:

make clean build

Run all tests via local drone

drone exec --local --build-event "pull_request"

Run sqlite integrations tests

Start tests

make test-sqlite

Run mysql integrations tests

Setup a mysql database inside docker

docker run -e "MYSQL_DATABASE=test" -e "MYSQL_ALLOW_EMPTY_PASSWORD=yes" --rm --name mysql mysql:5.7 #(just ctrl-c to stop db and clean the container) 

Start tests based on the database container

TEST_MYSQL_HOST="$(docker inspect -f '{{range .NetworkSettings.Networks}}{{.IPAddress}}{{end}}' mysql):3306" TEST_MYSQL_DBNAME=test TEST_MYSQL_USERNAME=root TEST_MYSQL_PASSWORD='' make test-mysql

Run pgsql integrations tests

Setup a pgsql database inside docker

docker run -e "POSTGRES_DB=test" --rm --name pgsql postgres:9.5 #(just ctrl-c to stop db and clean the container) 

Start tests based on the database container

TEST_PGSQL_HOST=$(docker inspect -f '{{range .NetworkSettings.Networks}}{{.IPAddress}}{{end}}' pgsql) TEST_PGSQL_DBNAME=test TEST_PGSQL_USERNAME=postgres TEST_PGSQL_PASSWORD=postgres make test-pgsql

Running individual tests

Example command to run GPG test with sqlite backend:

go test -c code.gitea.io/gitea/integrations \
  -o integrations.sqlite.test -tags 'sqlite' &&
  GITEA_ROOT="$GOPATH/src/code.gitea.io/gitea" \
  GITEA_CONF=integrations/sqlite.ini ./integrations.sqlite.test \
  -test.v -test.run GPG