0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-10-30 18:59:12 +01:00
gitea/routers/common
KN4CK3R 637451a45e
Rework markup link rendering (#26745)
Fixes #26548

This PR refactors the rendering of markup links. The old code uses
`strings.Replace` to change some urls while the new code uses more
context to decide which link should be generated.

The added tests should ensure the same output for the old and new
behaviour (besides the bug).

We may need to refactor the rendering a bit more to make it clear how
the different helper methods render the input string. There are lots of
options (resolve links / images / mentions / git hashes / emojis / ...)
but you don't really know what helper uses which options. For example,
we currently support images in the user description which should not be
allowed I think:

<details>
  <summary>Profile</summary> 

https://try.gitea.io/KN4CK3R

![grafik](https://github.com/go-gitea/gitea/assets/1666336/109ae422-496d-4200-b52e-b3a528f553e5)

</details>

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-01-15 08:49:24 +00:00
..
auth.go Extract auth middleware from service (#27028) 2023-09-12 08:15:16 +02:00
db.go Avoid cycle-redirecting user/login page (#28636) 2023-12-30 08:48:34 +00:00
errpage.go Clean up template locale usage (#27856) 2023-10-31 22:11:48 +08:00
errpage_test.go Clean up template locale usage (#27856) 2023-10-31 22:11:48 +08:00
markup.go Rework markup link rendering (#26745) 2024-01-15 08:49:24 +00:00
middleware.go Rewrite logger system (#24726) 2023-05-21 22:35:11 +00:00
middleware_test.go Support sanitising the URL by removing extra slashes in the URL (#21333) 2023-03-04 21:31:24 +08:00
redirect.go Use fetch to send requests to create issues/comments (#25258) 2023-06-16 06:32:43 +00:00
serve.go Less naked returns (#25713) 2023-07-07 05:31:56 +00:00