0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-11-15 06:21:23 +01:00
gitea/models/issues
yp05327 e61e9a36b7
Fix PullRequestList.GetIssueIDs's logic (#31352)
fix a bug from #30490

`prs.GetIssueIDs()` will also be used in other places, e.g.
`InvalidateCodeComments`
so we should not add `if pr.Issue == nil` in it, or if `pr.Issue` is
already loaded, you will not get the issueID in the results list and
this is not an expected result.

So this will caused a bug:
before calling `InvalidateCodeComments`, all `pr.Issues` in `prs` are
loaded, so `issueIDs` in this function will always be `[]`.

![image](https://github.com/go-gitea/gitea/assets/18380374/ef94d9d2-0bf9-455a-abd6-4d5e6497db7c)
2024-06-13 09:42:07 +00:00
..
assignees.go Performance improvements for pull request list API (#30490) 2024-05-31 12:10:11 +00:00
assignees_test.go Remove deadcode under models/issues (#28536) 2023-12-19 20:12:02 +01:00
comment.go Prevent simultaneous editing of comments and issues (#31053) 2024-05-27 15:34:18 +00:00
comment_code.go Use repo as of renderctx's member rather than a repoPath on metas (#29222) 2024-05-30 07:04:01 +00:00
comment_list.go Only update poster in issue/comment list if it has been loaded (#31216) 2024-06-02 10:32:20 +08:00
comment_test.go More db.DefaultContext refactor (#27265) 2023-09-29 12:12:54 +00:00
content_history.go Fix issue & comment history bugs (#29525) 2024-03-01 16:46:02 +00:00
content_history_test.go Fix issue & comment history bugs (#29525) 2024-03-01 16:46:02 +00:00
dependency.go Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
dependency_test.go Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
issue.go Performance improvements for pull request list API (#30490) 2024-05-31 12:10:11 +00:00
issue_index.go Another round of db.DefaultContext refactor (#27103) 2023-09-25 13:17:37 +00:00
issue_label.go Performance improvements for pull request list API (#30490) 2024-05-31 12:10:11 +00:00
issue_label_test.go Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
issue_list.go Only update poster in issue/comment list if it has been loaded (#31216) 2024-06-02 10:32:20 +08:00
issue_list_test.go Add context parameter to some database functions (#26055) 2023-07-22 22:14:27 +08:00
issue_lock.go Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
issue_project.go Rename project board -> column to make the UI less confusing (#30170) 2024-05-27 08:59:54 +00:00
issue_search.go Enable unparam linter (#31277) 2024-06-11 18:47:45 +00:00
issue_stats.go Use db.ListOptions directly instead of Paginator interface to make it easier to use and fix performance of /pulls and /issues (#29990) 2024-03-24 18:51:08 +00:00
issue_test.go Allow non-admin users to delete review requests (#29057) 2024-02-24 12:38:43 +00:00
issue_update.go Prevent simultaneous editing of comments and issues (#31053) 2024-05-27 15:34:18 +00:00
issue_user.go Add combined index for issue_user.uid and issue_id (#28080) 2023-12-14 09:26:59 +00:00
issue_user_test.go Fix bug with sqlite load read (#26305) 2023-08-05 10:40:27 +08:00
issue_watch.go Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
issue_watch_test.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
issue_xref.go Add user blocking (#29028) 2024-03-04 08:16:03 +00:00
issue_xref_test.go Resolve lint for unused parameter and unnecessary type arguments (#30750) 2024-04-29 08:47:56 +00:00
label.go Refactor label.IsArchived() (#29750) 2024-03-13 07:04:07 +01:00
label_test.go Remove deadcode under models/issues (#28536) 2023-12-19 20:12:02 +01:00
main_test.go make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
milestone.go remove util.OptionalBool and related functions (#29513) 2024-03-02 16:42:31 +01:00
milestone_list.go remove util.OptionalBool and related functions (#29513) 2024-03-02 16:42:31 +01:00
milestone_test.go remove util.OptionalBool and related functions (#29513) 2024-03-02 16:42:31 +01:00
pull.go Performance improvements for pull request list API (#30490) 2024-05-31 12:10:11 +00:00
pull_list.go Fix PullRequestList.GetIssueIDs's logic (#31352) 2024-06-13 09:42:07 +00:00
pull_test.go Refactor StringsToInt64s (#29967) 2024-03-21 15:07:35 +00:00
reaction.go Add container.FilterSlice function (#30339) 2024-04-09 20:27:30 +08:00
review.go Fix automerge will not work because of some events haven't been triggered (#30780) 2024-05-21 23:23:22 +08:00
review_list.go Add container.FilterSlice function (#30339) 2024-04-09 20:27:30 +08:00
review_test.go Prevent re-review and dismiss review actions on closed and merged PRs (#30065) 2024-03-28 15:19:24 +00:00
stopwatch.go Remove deadcode under models/issues (#28536) 2023-12-19 20:12:02 +01:00
stopwatch_test.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
tracked_time.go Update misspell to 0.5.1 and add misspellings.csv (#30573) 2024-04-27 08:03:49 +00:00
tracked_time_test.go remove util.OptionalBool and related functions (#29513) 2024-03-02 16:42:31 +01:00