0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-12-25 19:44:38 +01:00
gitea/models
zeripath d6fa138e7c
Only send webhook events to active system webhooks and only deliver to active hooks (#19234)
There is a bug in the system webhooks whereby the active state is not checked when
webhooks are prepared and there is a bug that deactivating webhooks do not prevent
queued deliveries.

* Only add SystemWebhooks to the prepareWebhooks list if they are active
* At the time of delivery if the underlying webhook is not active mark it
as "delivered" but with a failed delivery so it does not get delivered.

Fix #19220

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2022-03-28 11:17:21 +08:00
..
admin Propagate context and ensure git commands run in request context (#17868) 2022-01-19 23:26:57 +00:00
appstate
asymkey Fix the bug: deploy key with write access can not push (#19010) 2022-03-22 17:29:07 +08:00
auth Attempt to fix the webauthn migration again - part 3 (#18770) 2022-02-16 21:03:58 +00:00
avatars format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
db Move deletebeans into models/db (#18781) 2022-02-17 16:37:48 +08:00
fixtures Store the foreign ID of issues during migration (#18446) 2022-03-17 18:08:35 +01:00
foreignreference Store the foreign ID of issues during migration (#18446) 2022-03-17 18:08:35 +01:00
issues Show fullname on issue edits and gpg/ssh signing info (#18827) 2022-02-20 19:50:11 +00:00
migrations nit fix (#19116) 2022-03-17 20:04:36 +02:00
perm Team permission allow different unit has different permission (#17811) 2022-01-05 11:37:00 +08:00
repo Touch mirrors on even on fail to update (#19217) 2022-03-27 15:40:17 +01:00
unit Let MinUnitAccessMode return correct perm (#18675) 2022-02-08 21:16:17 +00:00
unittest Add separate SSH_USER config option (#17584) 2022-02-07 16:56:45 -05:00
user Restrict email address validation (#17688) 2022-03-14 18:39:54 +01:00
webhook Only send webhook events to active system webhooks and only deliver to active hooks (#19234) 2022-03-28 11:17:21 +08:00
access.go Team permission allow different unit has different permission (#17811) 2022-01-05 11:37:00 +08:00
access_test.go
action.go RSS/Atom support for Repos (#19055) 2022-03-13 17:40:47 +01:00
action_list.go RSS/Atom support for Repos (#19055) 2022-03-13 17:40:47 +01:00
action_test.go RSS/Atom support for Repos (#19055) 2022-03-13 17:40:47 +01:00
branches.go
branches_test.go
commit.go Collaborator trust model should trust collaborators (#18539) 2022-02-02 11:10:06 +01:00
commit_status.go
commit_status_test.go
consistency.go format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
consistency_test.go
engine_test.go
error.go
fixture_generation.go
fixture_test.go
helper.go
helper_directory.go
helper_environment.go Fix the bug: deploy key with write access can not push (#19010) 2022-03-22 17:29:07 +08:00
issue.go Fix showing issues in your repositories (#18916) 2022-03-23 23:57:09 +01:00
issue_assignees.go
issue_assignees_test.go
issue_comment.go Delete related notifications on issue deletion too (#18953) 2022-03-17 23:04:09 +01:00
issue_comment_list.go
issue_comment_test.go Propagate context and ensure git commands run in request context (#17868) 2022-01-19 23:26:57 +00:00
issue_dependency.go
issue_dependency_test.go
issue_label.go Be more lenient with label colors (#17752) 2022-02-07 21:21:02 +00:00
issue_label_test.go Be more lenient with label colors (#17752) 2022-02-07 21:21:02 +00:00
issue_list.go
issue_list_test.go
issue_lock.go Fix CheckRepoStats and reuse it during migration (#18264) 2022-01-17 19:31:58 +01:00
issue_milestone.go Only view milestones from current repo (#18414) 2022-01-26 20:01:35 +00:00
issue_milestone_test.go Fix CheckRepoStats and reuse it during migration (#18264) 2022-01-17 19:31:58 +01:00
issue_reaction.go add test coverage for original author conversion during migrations (#18506) 2022-02-01 13:20:28 -05:00
issue_reaction_test.go
issue_stopwatch.go Fix display time of milestones (#18753) 2022-02-16 00:50:10 +08:00
issue_stopwatch_test.go
issue_test.go Store the foreign ID of issues during migration (#18446) 2022-03-17 18:08:35 +01:00
issue_tracked_time.go Fix display time of milestones (#18753) 2022-02-16 00:50:10 +08:00
issue_tracked_time_test.go Refactor SecToTime() function (#18863) 2022-02-28 23:57:20 +01:00
issue_user.go
issue_user_test.go
issue_watch.go
issue_watch_test.go
issue_xref.go Lock gofumpt to v0.3.0 and run it (#18866) 2022-02-23 20:16:07 +00:00
issue_xref_test.go Propagate context and ensure git commands run in request context (#17868) 2022-01-19 23:26:57 +00:00
lfs.go Improve SyncMirrors logging (#19045) 2022-03-10 10:09:48 +00:00
lfs_lock.go
main_test.go
migrate.go Store the foreign ID of issues during migration (#18446) 2022-03-17 18:08:35 +01:00
migrate_test.go Store the foreign ID of issues during migration (#18446) 2022-03-17 18:08:35 +01:00
notification.go ignore missing comment for user notifications (#18954) 2022-03-03 16:18:26 +01:00
notification_test.go
org.go Move deletebeans into models/db (#18781) 2022-02-17 16:37:48 +08:00
org_team.go Cleanup protected branches when deleting users & teams (#19158) 2022-03-22 09:09:45 +08:00
org_team_test.go Add GetUserTeams (#18499) 2022-02-01 14:09:24 -05:00
org_test.go
project.go
project_board.go
project_issue.go
project_test.go
protected_tag.go
protected_tag_test.go
pull.go Propagate context and ensure git commands run in request context (#17868) 2022-01-19 23:26:57 +00:00
pull_list.go Don't delete branch if other PRs with this branch are open (#18164) 2022-01-03 20:45:58 +01:00
pull_test.go Don't delete branch if other PRs with this branch are open (#18164) 2022-01-03 20:45:58 +01:00
release.go add test coverage for original author conversion during migrations (#18506) 2022-02-01 13:20:28 -05:00
repo.go use xorm builder for models.getReviewers() (#19033) 2022-03-10 19:12:10 +01:00
repo_activity.go Propagate context and ensure git commands run in request context (#17868) 2022-01-19 23:26:57 +00:00
repo_collaboration.go
repo_collaboration_test.go
repo_generate.go Set the default branch for repositories generated from templates (#19136) 2022-03-27 03:56:28 +01:00
repo_generate_test.go
repo_list.go Allow to filter repositories by language in explore, user and organization repositories lists (#18430) 2022-01-28 13:29:04 +02:00
repo_list_test.go
repo_permission.go Team permission allow different unit has different permission (#17811) 2022-01-05 11:37:00 +08:00
repo_permission_test.go
repo_test.go Allow users to self-request a PR review (#19030) 2022-03-08 22:48:47 +01:00
repo_transfer.go
repo_transfer_test.go
review.go add test coverage for original author conversion during migrations (#18506) 2022-02-01 13:20:28 -05:00
review_test.go format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
statistic.go
task.go
token.go Use base32 for 2FA scratch token (#18384) 2022-01-26 12:10:10 +08:00
token_test.go
upload.go
user.go Cleanup protected branches when deleting users & teams (#19158) 2022-03-22 09:09:45 +08:00
user_heatmap.go
user_heatmap_test.go RSS/Atom support for Repos (#19055) 2022-03-13 17:40:47 +01:00
user_test.go
userlist.go
userlist_test.go