0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-11-15 06:21:23 +01:00
gitea/models
Henry Goodman 12cb1d2998
Allow force push to protected branches (#28086)
Fixes #22722 

### Problem
Currently, it is not possible to force push to a branch with branch
protection rules in place. There are often times where this is necessary
(CI workflows/administrative tasks etc).

The current workaround is to rename/remove the branch protection,
perform the force push, and then reinstate the protections.

### Solution
Provide an additional section in the branch protection rules to allow
users to specify which users with push access can also force push to the
branch. The default value of the rule will be set to `Disabled`, and the
UI is intuitive and very similar to the `Push` section.

It is worth noting in this implementation that allowing force push does
not override regular push access, and both will need to be enabled for a
user to force push.

This applies to manual force push to a remote, and also in Gitea UI
updating a PR by rebase (which requires force push)

This modifies the `BranchProtection` API structs to add:
- `enable_force_push bool`
- `enable_force_push_whitelist bool`
- `force_push_whitelist_usernames string[]`
- `force_push_whitelist_teams string[]`
- `force_push_whitelist_deploy_keys bool`

### Updated Branch Protection UI:

<img width="943" alt="image"
src="https://github.com/go-gitea/gitea/assets/79623665/7491899c-d816-45d5-be84-8512abd156bf">

### Pull Request `Update branch by Rebase` option enabled with source
branch `test` being a protected branch:


![image](https://github.com/go-gitea/gitea/assets/79623665/e018e6e9-b7b2-4bd3-808e-4947d7da35cc)
<img width="1038" alt="image"
src="https://github.com/go-gitea/gitea/assets/79623665/57ead13e-9006-459f-b83c-7079e6f4c654">

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-07-05 18:21:56 +00:00
..
actions Drop IDOrderDesc for listing Actions task and always order by id DESC (#31150) 2024-05-31 02:30:02 +00:00
activities Fix web notification icon not updated once you read all notifications (#31447) 2024-06-23 15:50:10 +08:00
admin
asymkey Enable more revive linter rules (#30608) 2024-04-22 11:48:42 +00:00
auth Add Passkey login support (#31504) 2024-06-29 22:50:03 +00:00
avatars Replace 10 more gt- classes with tw- (#29945) 2024-03-22 13:45:10 +00:00
db [Refactor] Unify repo search order by logic (#30876) 2024-06-13 09:13:11 +00:00
dbfs Enable unparam linter (#31277) 2024-06-11 18:47:45 +00:00
fixtures Fix wrong display of recently pushed notification (#25812) 2024-05-21 17:00:35 +00:00
git Allow force push to protected branches (#28086) 2024-07-05 18:21:56 +00:00
issues Refactor issue label selection (#31497) 2024-06-26 23:41:59 +00:00
migrations Allow force push to protected branches (#28086) 2024-07-05 18:21:56 +00:00
organization Fix wrong display of recently pushed notification (#25812) 2024-05-21 17:00:35 +00:00
packages Fix package list performance (#30520) 2024-04-20 13:07:00 +02:00
perm Clarify permission "HasAccess" behavior (#30585) 2024-04-20 03:15:04 +00:00
project Rename project board -> column to make the UI less confusing (#30170) 2024-05-27 08:59:54 +00:00
pull Add support for sha256 repositories (#23894) 2024-01-19 17:05:02 +01:00
repo Refactor repo unit "disabled" check (#31389) 2024-06-18 00:51:13 +00:00
secret Make runs-on support variable expression (#29468) 2024-03-08 06:14:35 +00:00
shared/types Refactor locale&string&template related code (#29165) 2024-02-14 21:48:45 +00:00
system Refactor deletion (#28610) 2023-12-25 21:25:29 +01:00
unit Refactor repo unit "disabled" check (#31389) 2024-06-18 00:51:13 +00:00
unittest Add some tests to clarify the "must-change-password" behavior (#30693) 2024-04-27 12:23:37 +00:00
user Fix duplicate sub-path for avatars (#31365) 2024-06-15 11:43:57 +08:00
webhook Store webhook event in database (#29145) 2024-03-07 23:18:38 +01:00
error.go Add merge style fast-forward-only (#28954) 2024-02-12 23:37:23 +01:00
fixture_generation.go Replace more db.DefaultContext (#27628) 2023-10-15 17:46:06 +02:00
fixture_test.go Replace more db.DefaultContext (#27628) 2023-10-15 17:46:06 +02:00
main_test.go make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
org.go Add user blocking (#29028) 2024-03-04 08:16:03 +00:00
org_team.go Clarify permission "HasAccess" behavior (#30585) 2024-04-20 03:15:04 +00:00
org_team_test.go Add user blocking (#29028) 2024-03-04 08:16:03 +00:00
org_test.go Add user blocking (#29028) 2024-03-04 08:16:03 +00:00
repo.go Refactor deletion (#28610) 2023-12-25 21:25:29 +01:00
repo_test.go Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
repo_transfer.go chore: use errors.New to replace fmt.Errorf with no parameters will much better (#30621) 2024-04-21 19:44:03 +00:00