0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-12-28 11:34:36 +01:00
gitea/docs/content/doc/usage
zeripath dd12384f22
Fix --port setting (#13288)
* Fix --port setting

Unfortunately there was an error in #13195 which set the --port
option before the settings were read. This PR fixes this by
moving applying this option to after the the settings are read

However, on looking further into this code I believe that the setPort
code was slightly odd.

Firstly, it may make sense to run the install page on a different
temporary port to the full system and this should be possible with
a --install-port option.

Secondy, if the --port option is provided we should apply it to both
otherwise there will be unusual behaviour on graceful restart

Thirdly, the documentation for --port says that the setting is
temporary - it should therefore not save its result to the configuration

(This however, does mean that authorized_keys and internal links may
not be correct. - I think we need to discuss this option further.)

Fix #13277

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Update cmd/web.go

* Apply suggestions from code review

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
2020-10-30 15:26:03 -04:00
..
backup-and-restore.en-us.md
backup-and-restore.zh-cn.md
backup-and-restore.zh-tw.md
command-line.en-us.md
email-setup.en-us.md
fail2ban-setup.en-us.md
git-lfs-support.md
https-support.md
issue-pull-request-templates.en-us.md
issue-pull-request-templates.zh-cn.md
linked-references.en-us.md
pull-request.en-us.md
pull-request.zh-cn.md
push-options.en-us.md
reverse-proxies.en-us.md
reverse-proxies.zh-cn.md
template-repositories.md