0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-05-17 02:44:11 +02:00
gitea/templates/repo/issue
wxiaoguang e7ef94e00f
Introduce customized HTML elements, fix incorrect AppUrl usages in templates (#22861)
This PR follows:
* #21986
* #22831

This PR also introduce customized HTML elements, which would also help
problems like:
* #17760
* #21429
* #21440

With customized HTML elements, there won't be any load-search-replace
operations, and it can avoid page flicking (which @silverwind cares a
lot).

Browser support:
https://developer.mozilla.org/en-US/docs/Web/API/Window/customElements

# FAQ

## Why the component has the prefix?

As usual, I would strongly suggest to add prefixes for our own/private
names. The dedicated prefix will avoid conflicts in the future, and it
makes it easier to introduce various 3rd components, like GitHub's
`relative-time` component. If there is no prefix, it's impossible to
introduce another public component with the same name in the future.

## Why the `custcomp.js` is loaded before HTML body? The `index.js` is
after HTML body.

Customized components must be registered before the content loading.
Otherwise there would be still some flicking.

`custcomp.js` should have its own dependencies and should be very light,
so it won't affect the page loading time too much.

## Why use `data-url` attribute but not use the `textContent`?

According to the standard, the `connectedCallback` occurs on the
tag-opening moment. The element's children are not ready yet.

## Why not use `{{.GuessCurrentOrigin $.ctx ...}}` to let backend decide
the absolute URL?

It's difficult for backend to guess the correct protocol(scheme)
correctly with zero configuration. Generating the absolute URL from
frontend can guarantee that the URL is 100% correct -- since the user is
visiting it.

# Screenshot

<details>

![image](https://user-images.githubusercontent.com/2114189/218256757-a267c8ba-3108-4755-9ae5-329f1b08f615.png)

</details>
2023-02-17 22:02:20 +08:00
..
fields Support Issue forms and PR forms (#20987) 2022-09-02 15:58:49 +08:00
labels Optimize html templates (#22080) 2022-12-09 21:34:51 +08:00
view_content Introduce customized HTML elements, fix incorrect AppUrl usages in templates (#22861) 2023-02-17 22:02:20 +08:00
branch_selector_field.tmpl Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
choose.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
comment_tab.tmpl Use link in UI which returned a relative url but not html_url which contains an absolute url (#21986) 2023-02-06 12:09:18 -06:00
label_precolors.tmpl Fix purple color in suggested label colors (#18241) 2022-01-11 12:11:40 -06:00
labels.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
list.tmpl Add context cache as a request level cache (#22294) 2023-02-15 21:37:34 +08:00
milestone_issues.tmpl Add context cache as a request level cache (#22294) 2023-02-15 21:37:34 +08:00
milestone_new.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
milestones.tmpl Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
navbar.tmpl Add some headings to repo views (#22869) 2023-02-12 20:20:12 +08:00
new.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
new_form.tmpl Add context cache as a request level cache (#22294) 2023-02-15 21:37:34 +08:00
openclose.tmpl Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
search.tmpl Issues: add Project filter to issues list and search (#22544) 2023-01-29 11:45:29 +08:00
view.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
view_content.tmpl Add context cache as a request level cache (#22294) 2023-02-15 21:37:34 +08:00
view_title.tmpl Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00