0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-11-11 04:21:21 +01:00
gitea/routers
Giteabot ec3f5f9992
Move database operations of merging a pull request to post receive hook and add a transaction (#30805) (#30888)
Backport #30805 by @lunny

Merging PR may fail because of various problems. The pull request may
have a dirty state because there is no transaction when merging a pull
request. ref
https://github.com/go-gitea/gitea/pull/25741#issuecomment-2074126393

This PR moves all database update operations to post-receive handler for
merging a pull request and having a database transaction. That means if
database operations fail, then the git merging will fail, the git client
will get a fail result.

There are already many tests for pull request merging, so we don't need
to add a new one.

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-05-08 14:17:18 +00:00
..
api Refactor AppURL usage (#30885) (#30891) 2024-05-08 13:34:43 +00:00
common Refactor AppURL usage (#30885) (#30891) 2024-05-08 13:34:43 +00:00
install Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
private Move database operations of merging a pull request to post receive hook and add a transaction (#30805) (#30888) 2024-05-08 14:17:18 +00:00
utils Refactor external URL detection (#29973) 2024-03-22 04:32:40 +08:00
web Refactor AppURL usage (#30885) (#30891) 2024-05-08 13:34:43 +00:00
init.go Make sure git version&feature are always prepared (#30877) (#30879) 2024-05-07 02:07:33 +00:00