0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-12-01 11:23:02 +01:00
gitea/services
zeripath b091c994b5
Comments on review should have the same sha (#13448)
* When replying to an outdated comment it should not appear on the files page

This happened because the comment took the latest commitID as its base instead of the
reviewID that it was replying to.

There was also no way of creating an already outdated comment - and a
reply to a review on an outdated line should be outdated.

Signed-off-by: Andrew Thornton <art27@cantab.net>

* fix test

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Fix broken migration

Signed-off-by: Andrew Thornton <art27@cantab.net>

* fix mssql

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Create temporary table because ... well MSSQL ...

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Create temporary table because ... well MSSQL ...

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Create temporary table because ... well MSSQL ...

Signed-off-by: Andrew Thornton <art27@cantab.net>

* fix mssql

Signed-off-by: Andrew Thornton <art27@cantab.net>

* move session within the batch

Signed-off-by: Andrew Thornton <art27@cantab.net>

* regen the sqlcmd each time round the loop

Signed-off-by: Andrew Thornton <art27@cantab.net>

* as per @lunny

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2020-11-09 01:15:09 -05:00
..
archiver [RFC] Make archival asynchronous (#11296) 2020-11-07 22:27:28 +02:00
comments Refactor pull request review (#8954) 2019-11-14 10:57:36 +08:00
externalaccount Allow externalID to be UUID (#8551) 2019-10-17 10:06:28 +08:00
gitdiff Alternative fix for HTML diff entity split (#13425) 2020-11-04 19:35:05 -05:00
issue Add review request api (#11355) 2020-10-20 14:18:25 -04:00
mailer Fix "only mail on mention" bug (#12775) 2020-09-09 15:08:55 -04:00
mirror Refactor: Move PushUpdateOptions (#13363) 2020-10-30 22:59:02 +01:00
pull Comments on review should have the same sha (#13448) 2020-11-09 01:15:09 -05:00
release Add the tag list page to the release page (#12096) 2020-11-02 18:10:22 -05:00
repository Fix a bug on refactoring (#13373) 2020-10-31 23:42:54 +08:00
wiki Update golangci-lint to version 1.31.0 (#13102) 2020-10-11 21:27:20 +01:00