0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-12-25 06:14:54 +01:00
gitea/services
zeripath 716fcfcf72
Make every not exist error unwrappable to a fs.ErrNotExist (#20891)
A lot of our code is repeatedly testing if individual errors are
specific types of Not Exist errors. This is repetitative and unnecesary.
`Unwrap() error` provides a common way of labelling an error as a
NotExist error and we can/should use this.

This PR has chosen to use the common `io/fs` errors e.g.
`fs.ErrNotExist` for our errors. This is in some ways not completely
correct as these are not filesystem errors but it seems like a
reasonable thing to do and would allow us to simplify a lot of our code
to `errors.Is(err, fs.ErrNotExist)` instead of
`package.IsErr...NotExist(err)`

I am open to suggestions to use a different base error - perhaps
`models/db.ErrNotExist` if that would be felt to be better.


Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: delvh <dev.lh@web.de>
2022-10-18 07:50:37 +02:00
..
agit
asymkey
attachment
auth
automerge
comments
context
cron Add system setting table with cache and also add cache supports for user setting (#18058) 2022-10-17 07:29:26 +08:00
externalaccount
forms
gitdiff
issue Add system setting table with cache and also add cache supports for user setting (#18058) 2022-10-17 07:29:26 +08:00
lfs
mailer
migrations Add system setting table with cache and also add cache supports for user setting (#18058) 2022-10-17 07:29:26 +08:00
mirror Add system setting table with cache and also add cache supports for user setting (#18058) 2022-10-17 07:29:26 +08:00
org
packages
pull
release Do not send notifications for draft releases (#21451) 2022-10-17 17:33:27 -04:00
repository Make every not exist error unwrappable to a fs.ErrNotExist (#20891) 2022-10-18 07:50:37 +02:00
task
user Add system setting table with cache and also add cache supports for user setting (#18058) 2022-10-17 07:29:26 +08:00
webhook
wiki Add system setting table with cache and also add cache supports for user setting (#18058) 2022-10-17 07:29:26 +08:00