0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-12-21 05:14:25 +01:00
gitea/models/organization
yp05327 daf2a4c047
Fix wrong display of recently pushed notification (#25812)
There's a bug in #25715: 
If user pushed a commit into another repo with same branch name, the
no-related repo will display the recently pushed notification
incorrectly.
It is simple to fix this, we should match the repo id in the sql query.


![image](https://github.com/go-gitea/gitea/assets/18380374/9411a926-16f1-419e-a1b5-e953af38bab1)
The latest commit is 2 weeks ago.

![image](https://github.com/go-gitea/gitea/assets/18380374/52f9ab22-4999-43ac-a86f-6d36fb1e0411)

The notification comes from another repo with same branch name:

![image](https://github.com/go-gitea/gitea/assets/18380374/a26bc335-8e5b-4b9c-a965-c3dc3fa6f252)


After:
In forked repo:

![image](https://github.com/go-gitea/gitea/assets/18380374/ce6ffc35-deb7-4be7-8b09-184207392f32)
New PR Link will redirect to the original repo:

![image](https://github.com/go-gitea/gitea/assets/18380374/7b98e76f-0c75-494c-9462-80cf9f98e786)
In the original repo:

![image](https://github.com/go-gitea/gitea/assets/18380374/5f6a821b-e51a-4bbd-9980-d9eb94a3c847)
New PR Link:

![image](https://github.com/go-gitea/gitea/assets/18380374/1ce8c879-9f11-4312-8c32-695d7d9af0df)

In the same repo:

![image](https://github.com/go-gitea/gitea/assets/18380374/64b56073-4d0e-40c4-b8a0-80be7a775f69)
New PR Link:

![image](https://github.com/go-gitea/gitea/assets/18380374/96e1b6a3-fb98-40ee-b2ee-648039fb0dcf)

08/15 Update:
Follow #26257, added permission check and logic fix mentioned in
https://github.com/go-gitea/gitea/pull/26257#discussion_r1294085203


2024/04/25 Update:
Fix #30611

---------

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-05-21 17:00:35 +00:00
..
main_test.go make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
mini_org.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
org.go Check the token's owner and repository when registering a runner (#30406) 2024-04-11 16:01:44 +08:00
org_repo.go Use RepositoryList instead of []*Repository (#25074) 2023-06-05 15:25:47 +08:00
org_test.go Resolve lint for unused parameter and unnecessary type arguments (#30750) 2024-04-29 08:47:56 +00:00
org_user.go Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
org_user_test.go Fix wrong display of recently pushed notification (#25812) 2024-05-21 17:00:35 +00:00
team.go Enable more revive linter rules (#30608) 2024-04-22 11:48:42 +00:00
team_invite.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
team_invite_test.go Replace 'userxx' with 'orgxx' in all test files when the user type is org (#27052) 2023-09-14 02:59:53 +00:00
team_list.go Another round of db.DefaultContext refactor (#27103) 2023-09-25 13:17:37 +00:00
team_repo.go Use RepositoryList instead of []*Repository (#25074) 2023-06-05 15:25:47 +08:00
team_test.go Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
team_unit.go Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
team_user.go Add user blocking (#29028) 2024-03-04 08:16:03 +00:00