0
0
Fork 0
mirror of https://github.com/go-gitea/gitea synced 2024-12-25 09:04:50 +01:00
gitea/modules/repository
Jason Song 09b56fc069
Distinguish LFS object errors to ignore missing objects during migration (#31702)
Fix #31137.

Replace #31623 #31697.

When migrating LFS objects, if there's any object that failed (like some
objects are losted, which is not really critical), Gitea will stop
migrating LFS immediately but treat the migration as successful.

This PR checks the error according to the [LFS api
doc](https://github.com/git-lfs/git-lfs/blob/main/docs/api/batch.md#successful-responses).

> LFS object error codes should match HTTP status codes where possible:
> 
> - 404 - The object does not exist on the server.
> - 409 - The specified hash algorithm disagrees with the server's
acceptable options.
> - 410 - The object was removed by the owner.
> - 422 - Validation error.

If the error is `404`, it's safe to ignore it and continue migration.
Otherwise, stop the migration and mark it as failed to ensure data
integrity of LFS objects.

And maybe we should also ignore others errors (maybe `410`? I'm not sure
what's the difference between "does not exist" and "removed by the
owner".), we can add it later when some users report that they have
failed to migrate LFS because of an error which should be ignored.
2024-07-31 10:29:48 +00:00
..
branch.go Fix adopt repository has empty object name in database (#31333) 2024-06-12 18:22:01 +08:00
branch_test.go Make "sync branch" also sync object format and add tests (#30878) 2024-05-06 17:02:30 +00:00
collaborator.go Add user blocking (#29028) 2024-03-04 08:16:03 +00:00
collaborator_test.go Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
commits.go
commits_test.go Make offline mode as default to no connect external avatar service by default (#28548) 2023-12-21 07:42:16 +00:00
create.go Add user blocking (#29028) 2024-03-04 08:16:03 +00:00
create_test.go
delete.go Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
env.go Move database operations of merging a pull request to post receive hook and add a transaction (#30805) 2024-05-07 07:36:48 +00:00
fork.go
hooks.go Always write proc-receive hook for all git versions (#29287) 2024-02-21 07:01:48 +00:00
init.go Move generate from module to service (#29465) 2024-02-28 14:40:36 +01:00
init_test.go
license.go
license_test.go
main_test.go
push.go Improve ObjectFormat interface (#28496) 2023-12-19 07:20:47 +00:00
repo.go Distinguish LFS object errors to ignore missing objects during migration (#31702) 2024-07-31 10:29:48 +00:00
repo_test.go Don't remove all mirror repository's releases when mirroring (#28817) 2024-01-26 06:18:19 +00:00
temp.go Enable more revive linter rules (#30608) 2024-04-22 11:48:42 +00:00