unpackFile: Always copy directories

If $src refers to a directory, then always copy it. Previously, we
checked the extension first, so if the directory had an extension like
.tar, unpackPhase would fail.

pkgs/build-support/fetchzip/default.nix

@@ -13,9 +13,7 @@
 , ... } @ args:
 
 fetchurl ({
-  # Remove the extension, because otherwise unpackPhase will get
+  name = args.name or (baseNameOf url);
-  # confused. FIXME: fix unpackPhase.
-  name = args.name or lib.removeSuffix ".zip" (lib.removeSuffix ".tar.gz" (baseNameOf url));
 
   recursiveHash = true;
 

pkgs/stdenv/generic/setup.sh

@@ -475,32 +475,36 @@ unpackFile() {
 
     header "unpacking source archive $curSrc" 3
 
-    case "$curSrc" in
+    if [ -d "$curSrc" ]; then
-        *.tar.xz | *.tar.lzma)
+
-            # Don't rely on tar knowing about .xz.
+        stripHash $curSrc
-            xz -d < $curSrc | tar xf -
+        cp -prd --no-preserve=timestamps $curSrc $strippedName
-            ;;
+
-        *.tar | *.tar.* | *.tgz | *.tbz2)
+    else
-            # GNU tar can automatically select the decompression method
+
-            # (info "(tar) gzip").
+        case "$curSrc" in
-            tar xf $curSrc
+            *.tar.xz | *.tar.lzma)
-            ;;
+                # Don't rely on tar knowing about .xz.
-        *.zip)
+                xz -d < $curSrc | tar xf -
-            unzip -qq $curSrc
+                ;;
-            ;;
+            *.tar | *.tar.* | *.tgz | *.tbz2)
-        *)
+                # GNU tar can automatically select the decompression method
-            if [ -d "$curSrc" ]; then
+                # (info "(tar) gzip").
-                stripHash $curSrc
+                tar xf $curSrc
-                cp -prd --no-preserve=timestamps $curSrc $strippedName
+                ;;
-            else
+            *.zip)
+                unzip -qq $curSrc
+                ;;
+            *)
                 if [ -z "$unpackCmd" ]; then
                     echo "source archive $curSrc has unknown type"
                     exit 1
                 fi
                 runSingleHook unpackCmd
-            fi
+                ;;
-            ;;
+        esac
-    esac
+
+    fi
 
     stopNest
 }