From 41b3688ba1222b61d19e6f810c9a1867eef69141 Mon Sep 17 00:00:00 2001 From: Robert Hensing Date: Thu, 23 Dec 2021 19:46:32 +0100 Subject: [PATCH] make-derivation.nix: Remove unnecessary TODO The goal was to keep the number of calls to a minimum, but that would come at the cost of clobbering git blame and possibly not improving readability. --- pkgs/stdenv/generic/make-derivation.nix | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pkgs/stdenv/generic/make-derivation.nix b/pkgs/stdenv/generic/make-derivation.nix index ac661d9429ff..afb6eed632a9 100644 --- a/pkgs/stdenv/generic/make-derivation.nix +++ b/pkgs/stdenv/generic/make-derivation.nix @@ -10,7 +10,7 @@ let inherit (stdenv) hostPlatform; }; - makeOverlayable = mkDerivationSimple: # TODO(@robert): turn mkDerivationSimple into let binding. + makeOverlayable = mkDerivationSimple: fnOrAttrs: if builtins.isFunction fnOrAttrs then makeDerivationExtensible mkDerivationSimple fnOrAttrs @@ -65,7 +65,6 @@ let in -# TODO(@roberth): inline makeOverlayable; reindenting whole rest of this file. makeOverlayable (overrideAttrs: