From a43660271b658ad067906c10f01473cf88871c2e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tor=20Hedin=20Br=C3=B8nner?= Date: Sun, 6 Oct 2019 07:08:11 +0200 Subject: [PATCH] gnome3.gnome-session: always run /etc/set-environment on startup gnomes-session sources its environment from a login shell. But if the systemd user environment already contains `__NIXOS_SET_ENVIRONMENT_DONE` the environment setup won't happen correctly. Simply unset this variable to ensure a fresh environment. This was previously handled by a GDM patch, but it no longer works reliably with gnome-sessions systemd session. We still need the GDM patch to handle running other sessions (eg. plasma). See https://github.com/NixOS/nixpkgs/issues/48255 for more info on the underlying issue. --- pkgs/desktops/gnome-3/core/gnome-session/fix-paths.patch | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkgs/desktops/gnome-3/core/gnome-session/fix-paths.patch b/pkgs/desktops/gnome-3/core/gnome-session/fix-paths.patch index fe4feaf70857..2399c656016a 100644 --- a/pkgs/desktops/gnome-3/core/gnome-session/fix-paths.patch +++ b/pkgs/desktops/gnome-3/core/gnome-session/fix-paths.patch @@ -1,6 +1,6 @@ --- a/gnome-session/gnome-session.in +++ b/gnome-session/gnome-session.in -@@ -3,11 +3,11 @@ +@@ -3,11 +3,13 @@ if [ "x$XDG_SESSION_TYPE" = "xwayland" ] && [ "x$XDG_SESSION_CLASS" != "xgreeter" ] && [ -n "$SHELL" ] && @@ -12,6 +12,8 @@ + ! (echo "$SHELL" | @grep@ -q "nologin"); then if [ "$1" != '-l' ]; then - exec bash -c "exec -l '$SHELL' -c '$0 -l $*'" ++ # Make sure the shell actually sets up the environment ++ unset __NIXOS_SET_ENVIRONMENT_DONE + exec @bash@ -c "exec -l '$SHELL' -c '$0 -l $*'" else shift