the merge actions comment on pull requests, seems this was broken by 2c71278a23
also:
- fix permissions on new manual rendering action
- drop unnecessary issues permission from the terraform action
we want to make sure that rendering the manual from markdown without
going through docbook produces (semantically) the same output as with
going through docbook. to ensure this we'll build the manual twice, run
each manual through html-tidy to generate a normalized form and diff
the normalized forms. we don't want to compare raw output because that
exposes us to a lot of whitespace we'd have to reproduce exactly in the
MD render.
this check may be relaxed even further in the future, but hopefully not
by much.
the nixos manual should not use docbook for module option documentation,
only markdown, to make future transition to a markdown-only world easier
and less painful. this check will ensure that all options
documentation (even plain text that would not be interpreted specially
by neither markdown nor docbook) is declared as being markdown.
See https://github.com/Gabriel439:
Hi, there! 👋🏼
I renamed my GitHub account from @Gabriel439 to @Gabriella439, so if you got here from an old profile link you can visit my new profile here:
@Gabriella439
I created this placeholder account so that:
… people who visit old links to my profile can find my new profile
… other people cannot impersonate my old handle
… GitHub continues to redirect old links to my repositories indefinitely
Niklas Hambüchen noted in
https://github.com/NixOS/rfcs/pull/124#issuecomment-1113647856
that we can add a label description for the stale label that appears
when you hover over the label, or look on
https://github.com/NixOS/nixpkgs/labels
I set the description to be
> https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md
which is our page explaining the stale bot.
The stale bot comments/emails are a significant burden on our most
prodigious contributors, and the reason for their existence to orient
new contributors.
Since our stale bot's configuration is benign enough to ignore (it
does not close), I believe it is good enough to satisfy the new
contributor orientation with the label description.
Therefore, this commit disables commenting when labeling an issue or
PR stale.
With the re-implementation in Python merged[1], it no longer makes sense
for me to track issues and pull requests. I did this originally because
people were forgetting (rightfully so) to run tests against all that
proprietary stuff we have in nixpkgs that is using autoPatchelfHook.
We still can't test these automatically but with me no longer being the
author of the code, I hereby drop my entry in CODEOWNERS and instead
replace it with layus, who's the author of the rewrite.
[1]: https://github.com/NixOS/nixpkgs/pull/149731
Signed-off-by: aszlig <aszlig@nix.build>
