mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-11-15 22:36:23 +01:00
e0464e4788
In preparation for the deprecation of `stdenv.isX`. These shorthands are not conducive to cross-compilation because they hide the platforms. Darwin might get cross-compilation for which the continued usage of `stdenv.isDarwin` will get in the way One example of why this is bad and especially affects compiler packages https://www.github.com/NixOS/nixpkgs/pull/343059 There are too many files to go through manually but a treewide should get users thinking when they see a `hostPlatform.isX` in a place where it doesn't make sense. ``` fd --type f "\.nix" | xargs sd --fixed-strings "stdenv.is" "stdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenv'.is" "stdenv'.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "clangStdenv.is" "clangStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "gccStdenv.is" "gccStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "stdenvNoCC.is" "stdenvNoCC.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "inherit (stdenv) is" "inherit (stdenv.hostPlatform) is" fd --type f "\.nix" | xargs sd --fixed-strings "buildStdenv.is" "buildStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "effectiveStdenv.is" "effectiveStdenv.hostPlatform.is" fd --type f "\.nix" | xargs sd --fixed-strings "originalStdenv.is" "originalStdenv.hostPlatform.is" ```
113 lines
3.5 KiB
Nix
113 lines
3.5 KiB
Nix
{ stdenv
|
|
, fetchurl
|
|
, fetchzip
|
|
, lib
|
|
, emptyDirectory
|
|
, linkFarm
|
|
, jam
|
|
, openssl
|
|
, CoreServices
|
|
, Foundation
|
|
, Security
|
|
, testers
|
|
}:
|
|
|
|
let
|
|
opensslStatic = openssl.override {
|
|
static = true;
|
|
};
|
|
androidZlibContrib =
|
|
let
|
|
src = fetchzip {
|
|
url = "https://android.googlesource.com/platform/external/zlib/+archive/61174f4fd262c6075f88768465f308aae95a2f04.tar.gz";
|
|
sha256 = "sha256-EMzKAHcEWOUugcHKH2Fj3ZaIHC9UlgO4ULKe3RvgxvI=";
|
|
stripRoot = false;
|
|
};
|
|
in
|
|
linkFarm "android-zlib-contrib" [
|
|
# We only want to keep the contrib directory as the other files conflict
|
|
# with p4's own zlib files. (For the same reason, we can't use the
|
|
# cone-based Git sparse checkout, either.)
|
|
{ name = "contrib"; path = "${src}/contrib"; }
|
|
];
|
|
in
|
|
stdenv.mkDerivation (finalAttrs: rec {
|
|
pname = "p4";
|
|
version = "2024.1/2596294";
|
|
|
|
src = fetchurl {
|
|
# Upstream replaces minor versions, so use archived URL.
|
|
url = "https://web.archive.org/web/20240526153453id_/https://ftp.perforce.com/perforce/r24.1/bin.tools/p4source.tgz";
|
|
sha256 = "sha256-6+DOJPeVzP4x0UsN9MlZRAyusapBTICX0BuyvVBQBC8=";
|
|
};
|
|
|
|
nativeBuildInputs = [ jam ];
|
|
|
|
buildInputs = lib.optionals stdenv.hostPlatform.isDarwin [ CoreServices Foundation Security ];
|
|
|
|
outputs = [ "out" "bin" "dev" ];
|
|
|
|
hardeningDisable = lib.optionals stdenv.hostPlatform.isDarwin [ "strictoverflow" ];
|
|
|
|
jamFlags =
|
|
[
|
|
"-sEXEC=bin.unix"
|
|
"-sCROSS_COMPILE=${stdenv.cc.targetPrefix}"
|
|
"-sMALLOC_OVERRIDE=no"
|
|
"-sSSLINCDIR=${lib.getDev opensslStatic}/include"
|
|
"-sSSLLIBDIR=${lib.getLib opensslStatic}/lib"
|
|
]
|
|
++ lib.optionals stdenv.cc.isClang [ "-sOSCOMP=clang" "-sCLANGVER=${stdenv.cc.cc.version}" ]
|
|
++ lib.optionals stdenv.cc.isGNU [ "-sOSCOMP=gcc" "-sGCCVER=${stdenv.cc.cc.version}" ]
|
|
++ lib.optionals stdenv.hostPlatform.isLinux [ "-sOSVER=26" ]
|
|
++ lib.optionals stdenv.hostPlatform.isDarwin [
|
|
"-sOSVER=1013"
|
|
"-sMACOSX_SDK=${emptyDirectory}"
|
|
"-sLIBC++DIR=${lib.getLib stdenv.cc.libcxx}/lib"
|
|
];
|
|
|
|
CCFLAGS =
|
|
# The file contrib/optimizations/slide_hash_neon.h is missing from the
|
|
# upstream distribution. It comes from the Android/Chromium sources.
|
|
lib.optionals stdenv.hostPlatform.isAarch64 [ "-I${androidZlibContrib}" ];
|
|
|
|
"C++FLAGS" =
|
|
# Avoid a compilation error that only occurs for 4-byte longs.
|
|
lib.optionals stdenv.hostPlatform.isi686 [ "-Wno-narrowing" ]
|
|
# See the "Header dependency changes" section of
|
|
# https://www.gnu.org/software/gcc/gcc-11/porting_to.html for more
|
|
# information on why we need to include these.
|
|
++ lib.optionals
|
|
(stdenv.cc.isClang || (stdenv.cc.isGNU && lib.versionAtLeast stdenv.cc.cc.version "11.0.0"))
|
|
[ "-include" "limits" "-include" "thread" ];
|
|
|
|
buildPhase = ''
|
|
runHook preBuild
|
|
jam $jamFlags -j$NIX_BUILD_CORES p4
|
|
jam $jamFlags -j$NIX_BUILD_CORES -sPRODUCTION=yes p4api.tar
|
|
runHook postBuild
|
|
'';
|
|
|
|
installPhase = ''
|
|
runHook preInstall
|
|
mkdir -p $bin/bin $dev $out
|
|
cp bin.unix/p4 $bin/bin
|
|
cp -r bin.unix/p4api-*/include $dev
|
|
cp -r bin.unix/p4api-*/lib $out
|
|
runHook postInstall
|
|
'';
|
|
|
|
passthru.tests.version = testers.testVersion {
|
|
package = finalAttrs.finalPackage;
|
|
command = "p4 -V";
|
|
};
|
|
|
|
meta = with lib; {
|
|
description = "Perforce Helix Core command-line client and APIs";
|
|
homepage = "https://www.perforce.com";
|
|
license = licenses.bsd2;
|
|
mainProgram = "p4";
|
|
platforms = platforms.unix;
|
|
maintainers = with maintainers; [ corngood impl ];
|
|
};
|
|
})
|