mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-11-15 22:36:23 +01:00
58eb3d3806
I’ve been using https://github.com/Fuuzetsu/shellcheck-nix-attributes on most of my derivations, and attaching it to one derived from `mkShell` resulted in ``` shellcheck_buildPhase In /nix/store/8774inwznc87dwhac90winc9b5k6gmkb-nix-shell_shellcheck_buildPhase line 1: echo "------------------------------------------------------------" >>$out ^-- SC2129 (style): Consider using { cmd1; cmd2; } >> file instead of individual redirects. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "------------------------------------------------------------" >>"$out" In /nix/store/8774inwznc87dwhac90winc9b5k6gmkb-nix-shell_shellcheck_buildPhase line 2: echo " WARNING: the existence of this path is not guaranteed." >>$out ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo " WARNING: the existence of this path is not guaranteed." >>"$out" In /nix/store/8774inwznc87dwhac90winc9b5k6gmkb-nix-shell_shellcheck_buildPhase line 3: echo " It is an internal implementation detail for pkgs.mkShell." >>$out ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo " It is an internal implementation detail for pkgs.mkShell." >>"$out" In /nix/store/8774inwznc87dwhac90winc9b5k6gmkb-nix-shell_shellcheck_buildPhase line 4: echo "------------------------------------------------------------" >>$out ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo "------------------------------------------------------------" >>"$out" In /nix/store/8774inwznc87dwhac90winc9b5k6gmkb-nix-shell_shellcheck_buildPhase line 5: echo >> $out ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: echo >> "$out" In /nix/store/8774inwznc87dwhac90winc9b5k6gmkb-nix-shell_shellcheck_buildPhase line 7: export >> $out ^--^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: export >> "$out" For more information: https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ... https://www.shellcheck.net/wiki/SC2129 -- Consider using { cmd1; cmd2; } >>... ``` ——— https://garnix.io/build/qgxbameB This addresses the shellcheck complaints. |
||
|---|---|---|
| .. | ||
| add-opengl-runpath | ||
| agda | ||
| alternatives | ||
| appimage | ||
| bintools-wrapper | ||
| build-bazel-package | ||
| build-fhs-userenv | ||
| build-fhs-userenv-bubblewrap | ||
| build-graalvm-native-image | ||
| build-setupcfg | ||
| buildenv | ||
| cc-wrapper | ||
| coq | ||
| dhall | ||
| docker | ||
| dotnet | ||
| emacs | ||
| expand-response-params | ||
| fake-nss | ||
| fetchbitbucket | ||
| fetchbower | ||
| fetchbzr | ||
| fetchcvs | ||
| fetchdarcs | ||
| fetchdocker | ||
| fetchfirefoxaddon | ||
| fetchfossil | ||
| fetchgit | ||
| fetchgitea | ||
| fetchgithub | ||
| fetchgitiles | ||
| fetchgitlab | ||
| fetchgitlocal | ||
| fetchgx | ||
| fetchhg | ||
| fetchipfs | ||
| fetchmavenartifact | ||
| fetchmtn | ||
| fetchnextcloudapp | ||
| fetchpatch | ||
| fetchrepoorcz | ||
| fetchrepoproject | ||
| fetchs3 | ||
| fetchsavannah | ||
| fetchsourcehut | ||
| fetchsvn | ||
| fetchsvnrevision | ||
| fetchsvnssh | ||
| fetchurl | ||
| fetchzip | ||
| flutter | ||
| go | ||
| icon-conv-tools | ||
| install-shell-files | ||
| java | ||
| kernel | ||
| libredirect | ||
| make-darwin-bundle | ||
| make-desktopitem | ||
| make-pkgconfigitem | ||
| make-startupitem | ||
| mkshell | ||
| mono-dll-fixer | ||
| nix-gitignore | ||
| node | ||
| nuke-references | ||
| ocaml | ||
| oci-tools | ||
| pkg-config-wrapper | ||
| portable-service | ||
| prefer-remote-fetch | ||
| references-by-popularity | ||
| release | ||
| remove-references-to | ||
| replace-secret | ||
| rust | ||
| setup-hooks | ||
| singularity-tools | ||
| snap | ||
| src-only | ||
| substitute | ||
| substitute-files | ||
| templaterpm | ||
| testers | ||
| trivial-builders | ||
| vm | ||
| wrapper-common | ||
| writers | ||
| build-maven.nix | ||
| build-pecl.nix | ||
| closure-info.nix | ||
| make-impure-test.nix | ||
| plugins.nix | ||
| replace-dependency.nix | ||
| setup-systemd-units.nix | ||
| source-from-head-fun.nix | ||
| trivial-builders.nix | ||