nixpkgs/nixos/modules/virtualisation
Erik Arvstedt 9a283a038d
nixos-container: fix nixpkgs container options being ignored
Since the introduction of option `containers.<name>.pkgs`, the
`nixpkgs.*` options (including `nixpkgs.pkgs`, `nixpkgs.config`, ...) were always
ignored in container configs, which broke existing containers.

This was due to `containers.<name>.pkgs` having two separate effects:
(1) It sets the source for the modules that are used to evaluate the container.
(2) It sets the `pkgs` arg (`_module.args.pkgs`) that is used inside the container
    modules.
    This happens even when the default value of `containers.<name>.pkgs` is unchanged, in which
    case the container `pkgs` arg is set to the pkgs of the host system.
    Previously, the `pkgs` arg was determined by the `containers.<name>.config.nixpkgs.*` options.

This commit reverts the breaking change (2) while adding a backwards-compatible way to achieve (1).
It removes option `pkgs` and adds option `nixpkgs` which implements (1).
Existing users of `pkgs` are informed by an error message to use option
`nixpkgs` or to achieve only (2) by setting option `containers.<name>.config.nixpkgs.pkgs`.
2021-01-15 12:49:42 +01:00
..
amazon-image.nix utillinux: rename to util-linux 2020-11-24 12:42:06 -05:00
amazon-init.nix
amazon-options.nix
anbox.nix
azure-agent-entropy.patch
azure-agent.nix utillinux: rename to util-linux 2020-11-24 12:42:06 -05:00
azure-bootstrap-blobs.nix
azure-common.nix
azure-config-user.nix
azure-config.nix
azure-image.nix nixos/modules: remove trailing whitespace 2020-08-07 14:45:39 +01:00
azure-images.nix
brightbox-config.nix
brightbox-image.nix utillinux: rename to util-linux 2020-11-24 12:42:06 -05:00
cloudstack-config.nix
container-config.nix
containers.nix nixos/{containers,cri-o,podman}: move copyFile to nixos/lib/utils 2020-09-24 10:01:47 +10:00
cri-o.nix nixos/{containers,cri-o,podman}: move copyFile to nixos/lib/utils 2020-09-24 10:01:47 +10:00
digital-ocean-config.nix
digital-ocean-image.nix
digital-ocean-init.nix
docker-image.nix
docker.nix systemd: switch to unified cgroup hierarchy by default 2020-11-19 16:56:46 +01:00
ec2-amis.nix ec2-amis: update AMIs to use gpt partition table 2020-11-05 20:58:08 -05:00
ec2-data.nix
ec2-metadata-fetcher.nix {ec2,openstack}-metadata-fetcher: unconditionally fetch metadata 2020-11-22 11:04:46 +10:00
ecs-agent.nix
gce-images.nix
google-compute-config.nix
google-compute-image.nix
grow-partition.nix
hyperv-guest.nix
hyperv-image.nix virtualisation/hyperv-image: remove diskImage after vhdx is generated 2020-05-20 19:56:38 -04:00
kvmgt.nix nixos/kvmgt: allow multiple uuids on same mdev 2020-05-30 12:13:54 -04:00
libvirtd.nix libvirtd: don't start libvirtd-tcp.socket by default 2020-07-08 19:50:23 -04:00
lxc-container.nix
lxc.nix Revert "apparmor: fix and improve the service" 2020-10-07 12:22:18 +02:00
lxcfs.nix
lxd.nix Revert "apparmor: fix and improve the service" 2020-10-07 12:22:18 +02:00
nixos-containers.nix nixos-container: fix nixpkgs container options being ignored 2021-01-15 12:49:42 +01:00
oci-containers.nix
openstack-config.nix nixos: openstack: have its own metadata fetcher expression 2020-11-18 11:42:32 -05:00
openstack-metadata-fetcher.nix {ec2,openstack}-metadata-fetcher: unconditionally fetch metadata 2020-11-22 11:04:46 +10:00
openvswitch.nix
parallels-guest.nix
podman.nix nixos/{containers,cri-o,podman}: move copyFile to nixos/lib/utils 2020-09-24 10:01:47 +10:00
qemu-guest-agent.nix nixos/qemu-guest-agent: make the QEMU guest agent package configurable 2020-10-19 17:58:10 +02:00
qemu-vm.nix utillinux: rename to util-linux 2020-11-24 12:42:06 -05:00
railcar.nix treewide: completely remove types.loaOf 2020-09-02 00:42:50 +02:00
spice-usb-redirection.nix fixup: address @jtojnar's review comments 2020-09-12 17:00:44 +02:00
vagrant-guest.nix nixos/vagrant-virtualbox-image: init (#101120) 2020-10-20 11:09:46 +02:00
vagrant-virtualbox-image.nix nixos/vagrant-virtualbox-image: init (#101120) 2020-10-20 11:09:46 +02:00
virtualbox-guest.nix nixos/virtualbox-guest: add vmware driver 2020-06-17 18:43:27 +02:00
virtualbox-host.nix
virtualbox-image.nix Merge pull request #60246 from dfordivam/virtualbox-add-extra-disk 2020-08-02 13:13:52 -04:00
vmware-guest.nix
vmware-image.nix virtualisation: add vmware-image (#88523) 2020-05-22 10:03:46 +02:00
xe-guest-utilities.nix
xen-dom0.nix utillinux: rename to util-linux 2020-11-24 12:42:06 -05:00
xen-domU.nix