mirror of
https://github.com/NixOS/nixpkgs.git
synced 2024-11-16 14:54:29 +01:00
40a35299fa
it's really easy to accidentally write the wrong systemd Exec* directive, ones
that works most of the time but fails when users include systemd metacharacters
in arguments that are interpolated into an Exec* directive. add a few functions
analogous to escapeShellArg{,s} and some documentation on how and when to use them.
45 lines
1.6 KiB
Nix
45 lines
1.6 KiB
Nix
import ./make-test-python.nix ({ pkgs, ... }:
|
|
|
|
let
|
|
echoAll = pkgs.writeScript "echo-all" ''
|
|
#! ${pkgs.runtimeShell}
|
|
for s in "$@"; do
|
|
printf '%s\n' "$s"
|
|
done
|
|
'';
|
|
# deliberately using a local empty file instead of pkgs.emptyFile to have
|
|
# a non-store path in the test
|
|
args = [ "a%Nything" "lang=\${LANG}" ";" "/bin/sh -c date" ./empty-file 4.2 23 ];
|
|
in
|
|
{
|
|
name = "systemd-escaping";
|
|
|
|
machine = { pkgs, lib, utils, ... }: {
|
|
systemd.services.echo =
|
|
assert !(builtins.tryEval (utils.escapeSystemdExecArgs [ [] ])).success;
|
|
assert !(builtins.tryEval (utils.escapeSystemdExecArgs [ {} ])).success;
|
|
assert !(builtins.tryEval (utils.escapeSystemdExecArgs [ null ])).success;
|
|
assert !(builtins.tryEval (utils.escapeSystemdExecArgs [ false ])).success;
|
|
assert !(builtins.tryEval (utils.escapeSystemdExecArgs [ (_:_) ])).success;
|
|
{ description = "Echo to the journal";
|
|
serviceConfig.Type = "oneshot";
|
|
serviceConfig.ExecStart = ''
|
|
${echoAll} ${utils.escapeSystemdExecArgs args}
|
|
'';
|
|
};
|
|
};
|
|
|
|
testScript = ''
|
|
machine.wait_for_unit("multi-user.target")
|
|
machine.succeed("systemctl start echo.service")
|
|
# skip the first 'Starting <service> ...' line
|
|
logs = machine.succeed("journalctl -u echo.service -o cat").splitlines()[1:]
|
|
assert "a%Nything" == logs[0]
|
|
assert "lang=''${LANG}" == logs[1]
|
|
assert ";" == logs[2]
|
|
assert "/bin/sh -c date" == logs[3]
|
|
assert "/nix/store/ij3gw72f4n5z4dz6nnzl1731p9kmjbwr-empty-file" == logs[4]
|
|
assert "4.2" in logs[5] # toString produces extra fractional digits!
|
|
assert "23" == logs[6]
|
|
'';
|
|
})
|