From 11860637e116717efa14149f17d8b941d1e5db5e Mon Sep 17 00:00:00 2001
From: Erik Johnston <erik@matrix.org>
Date: Wed, 6 Apr 2016 10:12:30 +0100
Subject: [PATCH] Tests

---
 tests/test_dns.py | 33 ++++++++++++++++++++++++++++++---
 1 file changed, 30 insertions(+), 3 deletions(-)

diff --git a/tests/test_dns.py b/tests/test_dns.py
index e006ed1a5..c394c57ee 100644
--- a/tests/test_dns.py
+++ b/tests/test_dns.py
@@ -21,6 +21,8 @@ from mock import Mock
 
 from synapse.http.endpoint import resolve_service
 
+from tests.utils import MockClock
+
 
 class DnsTestCase(unittest.TestCase):
 
@@ -63,12 +65,37 @@ class DnsTestCase(unittest.TestCase):
         self.assertEquals(servers[0].host, ip_address)
 
     @defer.inlineCallbacks
-    def test_from_cache(self):
+    def test_from_cache_expired_and_dns_fail(self):
         dns_client_mock = Mock()
         dns_client_mock.lookupService.return_value = defer.fail(error.DNSServerError())
 
         service_name = "test_service.examle.com"
 
+        entry = Mock(spec_set=["expires"])
+        entry.expires = 0
+
+        cache = {
+            service_name: [entry]
+        }
+
+        servers = yield resolve_service(
+            service_name, dns_client=dns_client_mock, cache=cache
+        )
+
+        dns_client_mock.lookupService.assert_called_once_with(service_name)
+
+        self.assertEquals(len(servers), 1)
+        self.assertEquals(servers, cache[service_name])
+
+    @defer.inlineCallbacks
+    def test_from_cache(self):
+        clock = MockClock()
+
+        dns_client_mock = Mock(spec_set=['lookupService'])
+        dns_client_mock.lookupService = Mock(spec_set=[])
+
+        service_name = "test_service.examle.com"
+
         entry = Mock(spec_set=["expires"])
         entry.expires = 999999999
 
@@ -77,10 +104,10 @@ class DnsTestCase(unittest.TestCase):
         }
 
         servers = yield resolve_service(
-            service_name, dns_client=dns_client_mock, cache=cache
+            service_name, dns_client=dns_client_mock, cache=cache, clock=clock,
         )
 
-        dns_client_mock.lookupService.assert_called_once_with(service_name)
+        self.assertFalse(dns_client_mock.lookupService.called)
 
         self.assertEquals(len(servers), 1)
         self.assertEquals(servers, cache[service_name])