From 15edf23626a55ee38a8ee394bfcc8eaeff733c37 Mon Sep 17 00:00:00 2001
From: Shay <hillerys@element.io>
Date: Mon, 18 Jul 2022 12:35:45 -0700
Subject: [PATCH] Improve performance of query `
 _get_subset_users_in_room_with_profiles` (#13299)

---
 changelog.d/13299.misc                       | 1 +
 synapse/storage/databases/main/roommember.py | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
 create mode 100644 changelog.d/13299.misc

diff --git a/changelog.d/13299.misc b/changelog.d/13299.misc
new file mode 100644
index 000000000..a9d556687
--- /dev/null
+++ b/changelog.d/13299.misc
@@ -0,0 +1 @@
+Improve performance of query  `_get_subset_users_in_room_with_profiles`.
diff --git a/synapse/storage/databases/main/roommember.py b/synapse/storage/databases/main/roommember.py
index 105a51867..46ab6232d 100644
--- a/synapse/storage/databases/main/roommember.py
+++ b/synapse/storage/databases/main/roommember.py
@@ -243,7 +243,7 @@ class RoomMemberWorkerStore(EventsWorkerStore):
             txn: LoggingTransaction,
         ) -> Dict[str, ProfileInfo]:
             clause, ids = make_in_list_sql_clause(
-                self.database_engine, "m.user_id", user_ids
+                self.database_engine, "c.state_key", user_ids
             )
 
             sql = """