From 22a8838f626834c4ffc09761f4c5d65215cfc885 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sergio=20Migu=C3=A9ns?= <lonyelon@gmail.com>
Date: Mon, 24 May 2021 21:23:54 +0200
Subject: [PATCH] Fix docker image to not log at `/homeserver.log` (#10045)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Fixes #9970

Signed-off-by: Sergio Miguéns Iglesias lonyelon@lony.xyz
---
 changelog.d/10045.docker | 1 +
 docker/conf/log.config   | 4 +++-
 2 files changed, 4 insertions(+), 1 deletion(-)
 create mode 100644 changelog.d/10045.docker

diff --git a/changelog.d/10045.docker b/changelog.d/10045.docker
new file mode 100644
index 000000000..70b65b0a0
--- /dev/null
+++ b/changelog.d/10045.docker
@@ -0,0 +1 @@
+Fix bug introduced in Synapse 1.33.0 which caused a `Permission denied: '/homeserver.log'` error when starting Synapse with the generated log configuration. Contributed by Sergio Miguéns Iglesias.
diff --git a/docker/conf/log.config b/docker/conf/log.config
index 34572bc0f..a99462692 100644
--- a/docker/conf/log.config
+++ b/docker/conf/log.config
@@ -9,10 +9,11 @@ formatters:
 {% endif %}
 
 handlers:
+{% if LOG_FILE_PATH %}
   file:
     class: logging.handlers.TimedRotatingFileHandler
     formatter: precise
-    filename: {{ LOG_FILE_PATH or "homeserver.log" }}
+    filename: {{ LOG_FILE_PATH }}
     when: "midnight"
     backupCount: 6  # Does not include the current log file.
     encoding: utf8
@@ -29,6 +30,7 @@ handlers:
     # be written to disk.
     capacity: 10
     flushLevel: 30  # Flush for WARNING logs as well
+{% endif %}
 
   console:
     class: logging.StreamHandler