MirrorHub/synapse
0
0
Fork 1
mirror of https://mau.dev/maunium/synapse.git synced 2024-12-14 16:53:53 +01:00
Code Issues Projects Releases Wiki Activity

Don't forget to ratelimit calls outside of RegistrationHandler

Browse source
This commit is contained in:
Andrew Morgan 2019-11-06 12:01:54 +00:00
parent b33c4f7a82
commit 4059d61e26
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
synapse/handlers/register.py
View file

@ -168,7 +168,7 @@ class RegistrationHandler(BaseHandler):
Raises:
RegistrationError if there was a problem registering.
"""
yield self._check_registration_ratelimit(address)
yield self.check_registration_ratelimit(address)
yield self.auth.check_auth_blocking(threepid=threepid)
password_hash = None
@ -415,7 +415,7 @@ class RegistrationHandler(BaseHandler):
ratelimit=False,
)
def _check_registration_ratelimit(self, address):
def check_registration_ratelimit(self, address):
"""A simple helper method to check whether the registration rate limit has been hit
for a given IP address

2
synapse/replication/http/register.py
View file

@ -75,6 +75,8 @@ class ReplicationRegisterServlet(ReplicationEndpoint):
async def _handle_request(self, request, user_id):
content = parse_json_object_from_request(request)
await self.registration_handler.check_registration_ratelimit(content["address"])
await self.registration_handler.register_with_store(
user_id=user_id,
password_hash=content["password_hash"],