From 6c6d7c1ab6bdcc3d80b88d28d0191c38bf60750d Mon Sep 17 00:00:00 2001 From: Tulir Asokan Date: Sat, 16 Jan 2021 14:24:15 +0200 Subject: [PATCH] Remove bad pusher validation --- README.md | 1 + synapse/push/httppusher.py | 7 ------- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/README.md b/README.md index 73fe52c24..992fb7bdb 100644 --- a/README.md +++ b/README.md @@ -29,6 +29,7 @@ use the specific release tags. filtered away (e.g. `org.matrix.dummy_event` and `m.room.aliases`). * Config option to allow specific users to use timestamp massaging without being appservice users. +* Removed bad pusher URL validation. ## Configuration Generating a new config will include the `meow` section, but this is here for diff --git a/synapse/push/httppusher.py b/synapse/push/httppusher.py index e048b0d59..8787c6dbf 100644 --- a/synapse/push/httppusher.py +++ b/synapse/push/httppusher.py @@ -92,13 +92,6 @@ class HttpPusher(Pusher): url = self.data["url"] if not isinstance(url, str): raise PusherConfigException("'url' must be a string") - url_parts = urllib.parse.urlparse(url) - # Note that the specification also says the scheme must be HTTPS, but - # it isn't up to the homeserver to verify that. - if url_parts.path != "/_matrix/push/v1/notify": - raise PusherConfigException( - "'url' must have a path of '/_matrix/push/v1/notify'" - ) self.url = url self.http_client = hs.get_proxied_blacklisted_http_client()