When exposing group state, return is_openly_joinable

as opposed to join_policy, which is really only pertinent to the
synapse implementation of the group server.

By doing this we keep the group server concept extensible by
allowing arbitrarily complex rules for deciding whether a group
is openly joinable.

synapse/groups/groups_server.py

@@ -407,6 +407,11 @@ class GroupsServerHandler(object):
         group_description = yield self.store.get_group(group_id)
 
         if group_description:
+            join_policy = group_description['join_policy']
+            del group_description['join_policy']
+
+            group_description['is_openly_joinable'] = join_policy == "open"
+
             defer.returnValue(group_description)
         else:
             raise SynapseError(404, "Unknown group")