From 86af6b2f0ef92a317900fd4a4f6d3436ff8a011c Mon Sep 17 00:00:00 2001
From: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Date: Thu, 7 Oct 2021 12:20:03 +0100
Subject: [PATCH] Add a comment in _process_received_pdu (#11011)

---
 changelog.d/11011.misc               | 1 +
 synapse/handlers/federation_event.py | 3 +++
 2 files changed, 4 insertions(+)
 create mode 100644 changelog.d/11011.misc

diff --git a/changelog.d/11011.misc b/changelog.d/11011.misc
new file mode 100644
index 000000000..9a765435d
--- /dev/null
+++ b/changelog.d/11011.misc
@@ -0,0 +1 @@
+Clean up some of the federation event authentication code for clarity.
diff --git a/synapse/handlers/federation_event.py b/synapse/handlers/federation_event.py
index 243be4626..0645ce939 100644
--- a/synapse/handlers/federation_event.py
+++ b/synapse/handlers/federation_event.py
@@ -894,6 +894,9 @@ class FederationEventHandler:
                 backfilled=backfilled,
             )
         except AuthError as e:
+            # FIXME richvdh 2021/10/07 I don't think this is reachable. Let's log it
+            #   for now
+            logger.exception("Unexpected AuthError from _check_event_auth")
             raise FederationError("ERROR", e.code, e.msg, affected=event.event_id)
 
         await self._run_push_actions_and_persist_event(event, context, backfilled)