From 8d0097bef112c848d37b1d2f601eb979e89245f6 Mon Sep 17 00:00:00 2001 From: Patrick Cloke Date: Tue, 14 Jul 2020 15:51:13 -0400 Subject: [PATCH] Fix bug in per-room message retention policies. (#7850) --- changelog.d/7850.bugfix | 1 + synapse/storage/data_stores/main/room.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 changelog.d/7850.bugfix diff --git a/changelog.d/7850.bugfix b/changelog.d/7850.bugfix new file mode 100644 index 000000000..5f19a8904 --- /dev/null +++ b/changelog.d/7850.bugfix @@ -0,0 +1 @@ +Fix "AttributeError: 'str' object has no attribute 'get'" error message when applying per-room message retention policies. The bug was introduced in Synapse 1.7.0. diff --git a/synapse/storage/data_stores/main/room.py b/synapse/storage/data_stores/main/room.py index dace20e6d..b4817d693 100644 --- a/synapse/storage/data_stores/main/room.py +++ b/synapse/storage/data_stores/main/room.py @@ -916,7 +916,7 @@ class RoomBackgroundUpdateStore(SQLBaseStore): retention_policy = {} else: ev = json.loads(row["json"]) - retention_policy = json.dumps(ev["content"]) + retention_policy = ev["content"] self.db.simple_insert_txn( txn=txn,