MirrorHub/synapse
0
0
Fork 1
mirror of https://mau.dev/maunium/synapse.git synced 2024-12-14 17:13:54 +01:00
Code Issues Projects Releases Wiki Activity

don't hammer a new hit for every displayname and avatar_url when we already have them in the members list...

Browse source
This commit is contained in:
Matthew Hodgson 2014-08-16 13:22:18 +01:00
parent 98ed3d0222
commit b60283473a
1 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
webclient/room/room-controller.js
View file

@ -117,14 +117,26 @@ angular.module('RoomController', [])
var updateMemberList = function(chunk) { var updateMemberList = function(chunk) {
var isNewMember = !(chunk.target_user_id in $scope.members); var isNewMember = !(chunk.target_user_id in $scope.members);
if (isNewMember) { if (isNewMember) {
// FIXME: why are we copying these fields around inside chunk?
if ("state" in chunk.content) { if ("state" in chunk.content) {
chunk.presenceState = chunk.content.state; chunk.presenceState = chunk.content.state; // why is this renamed?
} }
if ("mtime_age" in chunk.content) { if ("mtime_age" in chunk.content) {
chunk.mtime_age = chunk.content.mtime_age; chunk.mtime_age = chunk.content.mtime_age;
} }
if ("displayname" in chunk.content) {
chunk.displayname = chunk.content.displayname;
}
if ("avatar_url" in chunk.content) {
chunk.avatar_url = chunk.content.avatar_url;
}
$scope.members[chunk.target_user_id] = chunk; $scope.members[chunk.target_user_id] = chunk;
/*
// *SURELY* we don't want to be hammering a new request for
// every displayname and profile picture URL. Hasn't it already
// been returned in the chunk? Hence commenting this out --Matthew
// get their display name and profile picture and set it to their // get their display name and profile picture and set it to their
// member entry in $scope.members. We HAVE to use $timeout with 0 delay // member entry in $scope.members. We HAVE to use $timeout with 0 delay
// to make this function run AFTER the current digest cycle, else the // to make this function run AFTER the current digest cycle, else the
@ -148,6 +160,7 @@ angular.module('RoomController', [])
} }
); );
}); });
*/
} }
else { else {
// selectively update membership else it will nuke the picture and displayname too :/ // selectively update membership else it will nuke the picture and displayname too :/