From c433f6109145f0cf6c80dd07ee118b68a3a0cd4e Mon Sep 17 00:00:00 2001
From: Andrew Morgan <andrew@amorgan.xyz>
Date: Tue, 22 Jan 2019 12:06:36 +0000
Subject: [PATCH] Ensure new filter is actually created

---
 synapse/api/filtering.py | 2 +-
 synapse/storage/state.py | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/synapse/api/filtering.py b/synapse/api/filtering.py
index 0d8957175..f3a056110 100644
--- a/synapse/api/filtering.py
+++ b/synapse/api/filtering.py
@@ -454,7 +454,7 @@ class Filter(object):
             filter: A new filter including the given rooms and the old
                     filter's rooms.
         """
-        newFilter = self
+        newFilter = Filter(self.filter_json)
         newFilter.rooms += room_ids
         return newFilter
 
diff --git a/synapse/storage/state.py b/synapse/storage/state.py
index b06467185..981d1e360 100644
--- a/synapse/storage/state.py
+++ b/synapse/storage/state.py
@@ -448,7 +448,6 @@ class StateGroupWorkerStore(EventsWorkerStore, SQLBaseStore):
         Returns:
             Deferred[str]: predecessor room id
         """
-
         state_ids = yield self.get_current_state_ids(room_id)
         create_id = state_ids.get((EventTypes.Create, ""))