mirror of
https://mau.dev/maunium/synapse.git
synced 2024-12-14 15:33:53 +01:00
Use dedicated get_local_users_in_room
to find local users when calculating join_authorised_via_users_server
of a /make_join
request (#13606)
Use dedicated `get_local_users_in_room` to find local users when calculating `join_authorised_via_users_server` ("the authorising user for joining a restricted room") of a `/make_join` request. Found while working on https://github.com/matrix-org/synapse/pull/13575#discussion_r953023755 but it's not related.
This commit is contained in:
parent
371db86a86
commit
c807b814ae
2 changed files with 4 additions and 6 deletions
1
changelog.d/13606.misc
Normal file
1
changelog.d/13606.misc
Normal file
|
@ -0,0 +1 @@
|
|||
Use dedicated `get_local_users_in_room(room_id)` function to find local users when calculating `join_authorised_via_users_server` of a `/make_join` request.
|
|
@ -129,12 +129,9 @@ class EventAuthHandler:
|
|||
else:
|
||||
users = {}
|
||||
|
||||
# Find the user with the highest power level.
|
||||
users_in_room = await self._store.get_users_in_room(room_id)
|
||||
# Only interested in local users.
|
||||
local_users_in_room = [
|
||||
u for u in users_in_room if get_domain_from_id(u) == self._server_name
|
||||
]
|
||||
# Find the user with the highest power level (only interested in local
|
||||
# users).
|
||||
local_users_in_room = await self._store.get_local_users_in_room(room_id)
|
||||
chosen_user = max(
|
||||
local_users_in_room,
|
||||
key=lambda user: users.get(user, users_default_level),
|
||||
|
|
Loading…
Reference in a new issue