2017-01-30 22:51:27 +01:00
|
|
|
# (c) 2017, Toshio Kuratomi <tkuratomi@ansible.com>
|
|
|
|
#
|
|
|
|
# This file is part of Ansible
|
|
|
|
#
|
|
|
|
# Ansible is free software: you can redistribute it and/or modify
|
|
|
|
# it under the terms of the GNU General Public License as published by
|
|
|
|
# the Free Software Foundation, either version 3 of the License, or
|
|
|
|
# (at your option) any later version.
|
|
|
|
#
|
|
|
|
# Ansible is distributed in the hope that it will be useful,
|
|
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
# GNU General Public License for more details.
|
|
|
|
#
|
|
|
|
# You should have received a copy of the GNU General Public License
|
|
|
|
# along with Ansible. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
|
|
|
|
# Make coding more python3-ish
|
|
|
|
from __future__ import (absolute_import, division, print_function)
|
|
|
|
__metaclass__ = type
|
|
|
|
|
2019-08-28 03:11:21 +02:00
|
|
|
import os.path
|
|
|
|
|
2017-01-30 22:51:27 +01:00
|
|
|
import pytest
|
|
|
|
|
|
|
|
import ansible.errors
|
|
|
|
|
|
|
|
from ansible.executor import module_common as amc
|
2019-02-28 08:52:02 +01:00
|
|
|
from ansible.executor.interpreter_discovery import InterpreterDiscoveryRequiredError
|
2017-03-23 21:35:05 +01:00
|
|
|
from ansible.module_utils.six import PY2
|
2017-01-30 22:51:27 +01:00
|
|
|
|
|
|
|
|
2019-08-28 03:11:21 +02:00
|
|
|
class TestStripComments:
|
2017-01-30 22:51:27 +01:00
|
|
|
def test_no_changes(self):
|
|
|
|
no_comments = u"""def some_code():
|
|
|
|
return False"""
|
|
|
|
assert amc._strip_comments(no_comments) == no_comments
|
|
|
|
|
|
|
|
def test_all_comments(self):
|
|
|
|
all_comments = u"""# This is a test
|
|
|
|
# Being as it is
|
|
|
|
# To be
|
|
|
|
"""
|
|
|
|
assert amc._strip_comments(all_comments) == u""
|
|
|
|
|
|
|
|
def test_all_whitespace(self):
|
|
|
|
# Note: Do not remove the spaces on the blank lines below. They're
|
|
|
|
# test data to show that the lines get removed despite having spaces
|
|
|
|
# on them
|
|
|
|
all_whitespace = u"""
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
\t\t\r\n
|
|
|
|
""" # nopep8
|
|
|
|
assert amc._strip_comments(all_whitespace) == u""
|
|
|
|
|
|
|
|
def test_somewhat_normal(self):
|
|
|
|
mixed = u"""#!/usr/bin/python
|
|
|
|
|
|
|
|
# here we go
|
|
|
|
def test(arg):
|
|
|
|
# this is a thing
|
|
|
|
thing = '# test'
|
|
|
|
return thing
|
|
|
|
# End
|
|
|
|
"""
|
|
|
|
mixed_results = u"""def test(arg):
|
|
|
|
thing = '# test'
|
|
|
|
return thing"""
|
|
|
|
assert amc._strip_comments(mixed) == mixed_results
|
|
|
|
|
|
|
|
|
2019-08-28 03:11:21 +02:00
|
|
|
class TestSlurp:
|
2017-01-30 22:51:27 +01:00
|
|
|
def test_slurp_nonexistent(self, mocker):
|
|
|
|
mocker.patch('os.path.exists', side_effect=lambda x: False)
|
|
|
|
with pytest.raises(ansible.errors.AnsibleError):
|
|
|
|
amc._slurp('no_file')
|
|
|
|
|
|
|
|
def test_slurp_file(self, mocker):
|
|
|
|
mocker.patch('os.path.exists', side_effect=lambda x: True)
|
|
|
|
m = mocker.mock_open(read_data='This is a test')
|
|
|
|
if PY2:
|
|
|
|
mocker.patch('__builtin__.open', m)
|
|
|
|
else:
|
|
|
|
mocker.patch('builtins.open', m)
|
|
|
|
assert amc._slurp('some_file') == 'This is a test'
|
|
|
|
|
|
|
|
def test_slurp_file_with_newlines(self, mocker):
|
|
|
|
mocker.patch('os.path.exists', side_effect=lambda x: True)
|
|
|
|
m = mocker.mock_open(read_data='#!/usr/bin/python\ndef test(args):\nprint("hi")\n')
|
|
|
|
if PY2:
|
|
|
|
mocker.patch('__builtin__.open', m)
|
|
|
|
else:
|
|
|
|
mocker.patch('builtins.open', m)
|
|
|
|
assert amc._slurp('some_file') == '#!/usr/bin/python\ndef test(args):\nprint("hi")\n'
|
|
|
|
|
|
|
|
|
2017-12-08 15:59:24 +01:00
|
|
|
@pytest.fixture
|
|
|
|
def templar():
|
2019-08-28 03:11:21 +02:00
|
|
|
class FakeTemplar:
|
2017-12-08 15:59:24 +01:00
|
|
|
def template(self, template_string, *args, **kwargs):
|
|
|
|
return template_string
|
|
|
|
|
|
|
|
return FakeTemplar()
|
|
|
|
|
|
|
|
|
2019-08-28 03:11:21 +02:00
|
|
|
class TestGetShebang:
|
2017-01-30 22:51:27 +01:00
|
|
|
"""Note: We may want to change the API of this function in the future. It isn't a great API"""
|
2017-12-08 15:59:24 +01:00
|
|
|
def test_no_interpreter_set(self, templar):
|
2019-02-28 08:52:02 +01:00
|
|
|
# normally this would return /usr/bin/python, but so long as we're defaulting to auto python discovery, we'll get
|
|
|
|
# an InterpreterDiscoveryRequiredError here instead
|
|
|
|
with pytest.raises(InterpreterDiscoveryRequiredError):
|
|
|
|
amc._get_shebang(u'/usr/bin/python', {}, templar)
|
2017-01-30 22:51:27 +01:00
|
|
|
|
2017-12-08 15:59:24 +01:00
|
|
|
def test_non_python_interpreter(self, templar):
|
|
|
|
assert amc._get_shebang(u'/usr/bin/ruby', {}, templar) == (None, u'/usr/bin/ruby')
|
2017-01-30 22:51:27 +01:00
|
|
|
|
2017-12-08 15:59:24 +01:00
|
|
|
def test_interpreter_set_in_task_vars(self, templar):
|
|
|
|
assert amc._get_shebang(u'/usr/bin/python', {u'ansible_python_interpreter': u'/usr/bin/pypy'}, templar) == \
|
2017-01-30 22:51:27 +01:00
|
|
|
(u'#!/usr/bin/pypy', u'/usr/bin/pypy')
|
|
|
|
|
2017-12-08 15:59:24 +01:00
|
|
|
def test_non_python_interpreter_in_task_vars(self, templar):
|
|
|
|
assert amc._get_shebang(u'/usr/bin/ruby', {u'ansible_ruby_interpreter': u'/usr/local/bin/ruby'}, templar) == \
|
2017-01-30 22:51:27 +01:00
|
|
|
(u'#!/usr/local/bin/ruby', u'/usr/local/bin/ruby')
|
|
|
|
|
2017-12-08 15:59:24 +01:00
|
|
|
def test_with_args(self, templar):
|
|
|
|
assert amc._get_shebang(u'/usr/bin/python', {u'ansible_python_interpreter': u'/usr/bin/python3'}, templar, args=('-tt', '-OO')) == \
|
2017-01-30 22:51:27 +01:00
|
|
|
(u'#!/usr/bin/python3 -tt -OO', u'/usr/bin/python3')
|
|
|
|
|
2017-12-08 15:59:24 +01:00
|
|
|
def test_python_via_env(self, templar):
|
|
|
|
assert amc._get_shebang(u'/usr/bin/python', {u'ansible_python_interpreter': u'/usr/bin/env python'}, templar) == \
|
2017-01-30 22:51:27 +01:00
|
|
|
(u'#!/usr/bin/env python', u'/usr/bin/env python')
|
2019-08-28 03:11:21 +02:00
|
|
|
|
|
|
|
|
|
|
|
class TestDetectionRegexes:
|
|
|
|
ANSIBLE_MODULE_UTIL_STRINGS = (
|
|
|
|
# Absolute collection imports
|
|
|
|
b'import ansible_collections.my_ns.my_col.plugins.module_utils.my_util',
|
|
|
|
b'from ansible_collections.my_ns.my_col.plugins.module_utils import my_util',
|
|
|
|
b'from ansible_collections.my_ns.my_col.plugins.module_utils.my_util import my_func',
|
|
|
|
# Absolute core imports
|
|
|
|
b'import ansible.module_utils.basic',
|
|
|
|
b'from ansible.module_utils import basic',
|
|
|
|
b'from ansible.module_utils.basic import AnsibleModule',
|
|
|
|
# Relative imports
|
|
|
|
b'from ..module_utils import basic',
|
|
|
|
b'from .. module_utils import basic',
|
|
|
|
b'from ....module_utils import basic',
|
|
|
|
b'from ..module_utils.basic import AnsibleModule',
|
|
|
|
)
|
|
|
|
NOT_ANSIBLE_MODULE_UTIL_STRINGS = (
|
|
|
|
b'from ansible import release',
|
|
|
|
b'from ..release import __version__',
|
|
|
|
b'from .. import release',
|
|
|
|
b'from ansible.modules.system import ping',
|
|
|
|
b'from ansible_collecitons.my_ns.my_col.plugins.modules import function',
|
|
|
|
)
|
|
|
|
|
|
|
|
OFFSET = os.path.dirname(os.path.dirname(amc.__file__))
|
|
|
|
CORE_PATHS = (
|
|
|
|
('%s/modules/from_role.py' % OFFSET, 'ansible/modules/from_role'),
|
|
|
|
('%s/modules/system/ping.py' % OFFSET, 'ansible/modules/system/ping'),
|
|
|
|
('%s/modules/cloud/amazon/s3.py' % OFFSET, 'ansible/modules/cloud/amazon/s3'),
|
|
|
|
)
|
|
|
|
|
|
|
|
COLLECTION_PATHS = (
|
|
|
|
('/root/ansible_collections/ns/col/plugins/modules/ping.py',
|
|
|
|
'ansible_collections/ns/col/plugins/modules/ping'),
|
|
|
|
('/root/ansible_collections/ns/col/plugins/modules/subdir/ping.py',
|
|
|
|
'ansible_collections/ns/col/plugins/modules/subdir/ping'),
|
|
|
|
)
|
|
|
|
|
|
|
|
@pytest.mark.parametrize('testcase', ANSIBLE_MODULE_UTIL_STRINGS)
|
|
|
|
def test_detect_new_style_python_module_re(self, testcase):
|
|
|
|
assert amc.NEW_STYLE_PYTHON_MODULE_RE.search(testcase)
|
|
|
|
|
|
|
|
@pytest.mark.parametrize('testcase', NOT_ANSIBLE_MODULE_UTIL_STRINGS)
|
|
|
|
def test_no_detect_new_style_python_module_re(self, testcase):
|
|
|
|
assert not amc.NEW_STYLE_PYTHON_MODULE_RE.search(testcase)
|
|
|
|
|
|
|
|
# pylint bug: https://github.com/PyCQA/pylint/issues/511
|
|
|
|
@pytest.mark.parametrize('testcase, result', CORE_PATHS) # pylint: disable=undefined-variable
|
|
|
|
def test_detect_core_library_path_re(self, testcase, result):
|
|
|
|
assert amc.CORE_LIBRARY_PATH_RE.search(testcase).group('path') == result
|
|
|
|
|
|
|
|
@pytest.mark.parametrize('testcase', (p[0] for p in COLLECTION_PATHS)) # pylint: disable=undefined-variable
|
|
|
|
def test_no_detect_core_library_path_re(self, testcase):
|
|
|
|
assert not amc.CORE_LIBRARY_PATH_RE.search(testcase)
|
|
|
|
|
|
|
|
@pytest.mark.parametrize('testcase, result', COLLECTION_PATHS) # pylint: disable=undefined-variable
|
|
|
|
def test_detect_collection_path_re(self, testcase, result):
|
|
|
|
assert amc.COLLECTION_PATH_RE.search(testcase).group('path') == result
|
|
|
|
|
|
|
|
@pytest.mark.parametrize('testcase', (p[0] for p in CORE_PATHS)) # pylint: disable=undefined-variable
|
|
|
|
def test_no_detect_collection_path_re(self, testcase):
|
|
|
|
assert not amc.COLLECTION_PATH_RE.search(testcase)
|