ansible/changelogs/fragments/47695-pamd-fix-idempotence-and-parsing-issues.yml

---
bugfixes:
- "pamd: update regex to allow leading dash and retain EOF newline (see https://github.com/ansible/ansible/issues/47418)"
- "pamd: fix state: updated idempotence (see https://github.com/ansible/ansible/issues/47083)"
- "pamd: fix state: args_present idempotence (see https://github.com/ansible/ansible/issues/47197)"
Backport/2.7/47695 - pamd fixes (#48307) * pamd: fixes for multiple issues (#47695) * Providing fix for #47083 in pamd.py * Providing fix for #47197 * Fixing pep8 errors * update regex to account for leading dash and VALID_TYPES with dashes as well * use a results dictionary and clean up unnecessary items * remove unnessecary return value. action is already reported in invocation output * make naming consistent across action returns * fix comparison so it checks equality instead of identity and indentation in update_rule() * make sure file always has EOF newline * updated regex to skip spacing between path and args and add rule arg regex to capture complex args * new module argument parsing code in function and DRY changes * remove unused has_rule method on PamdService class * fix error in parse_module_arguments() * updated args_present action to make it handle key value args and fail on complex bracketed arguments * pep8 and other fixes so units still work * suggested change - make version removed 2.8 Co-Authored-By: shepdelacreme <shepdelacreme@users.noreply.github.com> * add more error proof test to if statement (cherry picked from commit ef690e928f9f828a811a77a04374cd7dba223af2) * add changelog fragment for backport * add action return value back for backport 2018-11-13 02:36:55 +01:00			`---`
			`bugfixes:`
			`- "pamd: update regex to allow leading dash and retain EOF newline (see https://github.com/ansible/ansible/issues/47418)"`
			`- "pamd: fix state: updated idempotence (see https://github.com/ansible/ansible/issues/47083)"`
			`- "pamd: fix state: args_present idempotence (see https://github.com/ansible/ansible/issues/47197)"`