ansible/test/units/cli/arguments/test_optparse_helpers.py

# -*- coding: utf-8 -*-
# Copyright: (c) 2018, Ansible Project
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)

# Make coding more python3-ish
from __future__ import (absolute_import, division)
__metaclass__ = type

import pytest

from ansible.cli.arguments import optparse_helpers as opt_help


class TestOptparseHelpersVersion:

    def test_version(self):
        ver = opt_help.version('ansible-cli-test')
        assert 'ansible-cli-test' in ver
        assert 'python version' in ver
Split up the base_parser function The goal of breaking apart the base_parser() function is to get rid of a bunch of conditionals and parameters in the code and, instead, make code look like simple composition. When splitting, a choice had to be made as to whether this would operate by side effect (modifying a passed in parser) or side effect-free (returning a new parser everytime). Making a version that's side-effect-free appears to be fighting with the optparse API (it wants to work by creating a parser object, configuring the object, and then parsing the arguments with it) so instead, make it clear that our helper functions are modifying the passed in parser by (1) not returning the parser and (2) changing the function names to be more clear that it is operating by side-effect. Also move all of the generic optparse code, along with the argument context classes, into a new subdirectory. 2018-12-19 09:28:33 +01:00			`# -- coding: utf-8 --`
			`# Copyright: (c) 2018, Ansible Project`
			`# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)`

			`# Make coding more python3-ish`
			`from __future__ import (absolute_import, division)`
			`__metaclass__ = type`

			`import pytest`

Move the arguments module into cli/ and context_objects into utils * Note: Python2 is not as intelligent at detecting false import loops as Python3. context_objects.py cannot be added to cli/arguments because it would set up an import loop between cli/__init__.py, cli/arguments/context_objects.py, and context.py on Python2. ci_complete 2018-12-20 19:07:49 +01:00			`from ansible.cli.arguments import optparse_helpers as opt_help`
Split up the base_parser function The goal of breaking apart the base_parser() function is to get rid of a bunch of conditionals and parameters in the code and, instead, make code look like simple composition. When splitting, a choice had to be made as to whether this would operate by side effect (modifying a passed in parser) or side effect-free (returning a new parser everytime). Making a version that's side-effect-free appears to be fighting with the optparse API (it wants to work by creating a parser object, configuring the object, and then parsing the arguments with it) so instead, make it clear that our helper functions are modifying the passed in parser by (1) not returning the parser and (2) changing the function names to be more clear that it is operating by side-effect. Also move all of the generic optparse code, along with the argument context classes, into a new subdirectory. 2018-12-19 09:28:33 +01:00

			`class TestOptparseHelpersVersion:`

			`def test_version(self):`
			`ver = opt_help.version('ansible-cli-test')`
			`assert 'ansible-cli-test' in ver`
			`assert 'python version' in ver`