Fix nxos_banner removal idempotence issue in N1 images (#31259)

* Fix nxos_banner removal idempotence issue in N1 images

* handle pep8 error
This commit is contained in:
rahushen 2017-10-11 06:56:17 -04:00 committed by Trishna Guha
parent 7acb0bb187
commit 025386c56b

View file

@ -90,14 +90,17 @@ commands:
from ansible.module_utils.basic import AnsibleModule from ansible.module_utils.basic import AnsibleModule
from ansible.module_utils.nxos import load_config, run_commands from ansible.module_utils.nxos import load_config, run_commands
from ansible.module_utils.nxos import nxos_argument_spec, check_args from ansible.module_utils.nxos import nxos_argument_spec, check_args
import re
def map_obj_to_commands(want, have, module): def map_obj_to_commands(want, have, module):
commands = list() commands = list()
state = module.params['state'] state = module.params['state']
platform_regex = 'Nexus.*Switch'
if (state == 'absent' and (have.get('text') and have.get('text') != 'User Access Verification')): if state == 'absent':
commands.append('no banner %s' % module.params['banner']) if (have.get('text') and not ((have.get('text') == 'User Access Verification') or re.match(platform_regex, have.get('text')))):
commands.append('no banner %s' % module.params['banner'])
elif state == 'present' and want.get('text') != have.get('text'): elif state == 'present' and want.get('text') != have.get('text'):
banner_cmd = 'banner %s @\n%s\n@' % (module.params['banner'], want['text'].strip()) banner_cmd = 'banner %s @\n%s\n@' % (module.params['banner'], want['text'].strip())