cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Check rc and print error message if any.

Browse source 
It is probably good to use stdout before printing a generic error
message as well.
This commit is contained in:
Patrik Lundin 2014-08-28 16:33:39 +02:00 committed by Matt Clay
parent 38d8db473f
commit 03d4b76b14
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
lib/ansible/modules/system/service.py
View file

@ -1035,8 +1035,16 @@ class OpenBsdService(Service):
if self.module.check_mode: if self.module.check_mode:
self.module.exit_json(changed=True, msg="changing service enablement") self.module.exit_json(changed=True, msg="changing service enablement")
# XXX check rc ?
rc, stdout, stderr = self.execute_command("%s %s" % (self.enable_cmd, action)) rc, stdout, stderr = self.execute_command("%s %s" % (self.enable_cmd, action))
if rc != 0:
if stderr:
self.module.fail_json(msg=stderr)
elif stdout:
self.module.fail_json(msg=stdout)
else:
self.module.fail_json(msg="rcctl failed to modify service enablement")
self.changed = True self.changed = True
# =========================================== # ===========================================