cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Code smell test for specifying both required and default in FieldAttributes

Browse source
This commit is contained in:
Toshio Kuratomi 2015-12-09 08:23:45 -08:00
parent de703f81dd
commit 04fc3f118f
2 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
.travis.yml
View file

@ -24,6 +24,7 @@ script:
- ./test/code-smell/replace-urlopen.sh . - ./test/code-smell/replace-urlopen.sh .
- ./test/code-smell/use-compat-six.sh lib - ./test/code-smell/use-compat-six.sh lib
- ./test/code-smell/boilerplate.sh - ./test/code-smell/boilerplate.sh
- ./test/code-smell/required-and-default-attributes.sh
- if test x"$TOXENV" != x'py24' ; then tox ; fi - if test x"$TOXENV" != x'py24' ; then tox ; fi
- if test x"$TOXENV" = x'py24' ; then python2.4 -V && python2.4 -m compileall -fq -x 'module_utils/(a10|rax|openstack|ec2|gce).py' lib/ansible/module_utils ; fi - if test x"$TOXENV" = x'py24' ; then python2.4 -V && python2.4 -m compileall -fq -x 'module_utils/(a10|rax|openstack|ec2|gce).py' lib/ansible/module_utils ; fi
#- make -C docsite all #- make -C docsite all

10
test/code-smell/required-and-default-attributes.sh Executable file
View file

@ -0,0 +1,10 @@
#!/bin/sh
BASEDIR=${1-"lib/ansible"}
cd "$BASEDIR"
grep -r FieldAttribute . |grep 'default' | grep 'required'
if test $? -eq 0 ; then
exit 1
fi
exit 0