cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

gitlab_modules : remove misssing required parameter (#63690)

Browse source 
* gitlab_group: remove required=True on server_url param

* gitlab_project: remove required=True on server_url param

* Revert "Example incorrect: server_url is required argument (#63670)"

This reverts commit b02467961a.
This modification shouldn't have been made.
This parameter is deprecated and #60425 forget to remove the required
parameter
This commit is contained in:
Guillaume Martinez 2019-10-19 10:27:19 +02:00 committed by Abhijeet Kasurde
parent e0b4fafb22
commit 0af32a1093
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lib/ansible/modules/source_control/gitlab_group.py
View file

@ -87,7 +87,7 @@ options:
EXAMPLES = '''
- name: "Delete GitLab Group"
gitlab_group:
server_url: https://gitlab.example.com/
api_url: https://gitlab.example.com/
api_token: "{{ access_token }}"
validate_certs: False
name: my_first_group
@ -95,7 +95,7 @@ EXAMPLES = '''
- name: "Create GitLab Group"
gitlab_group:
server_url: https://gitlab.example.com/
api_url: https://gitlab.example.com/
validate_certs: True
api_username: dj-wasabi
api_password: "MySecretPassword"
@ -106,7 +106,7 @@ EXAMPLES = '''
# The group will by created at https://gitlab.dj-wasabi.local/super_parent/parent/my_first_group
- name: "Create GitLab SubGroup"
gitlab_group:
server_url: https://gitlab.example.com/
api_url: https://gitlab.example.com/
validate_certs: True
api_username: dj-wasabi
api_password: "MySecretPassword"
@ -277,7 +277,7 @@ def deprecation_warning(module):
def main():
argument_spec = basic_auth_argument_spec()
argument_spec.update(dict(
server_url=dict(type='str', required=True, removed_in_version="2.10"),
server_url=dict(type='str', removed_in_version="2.10"),
login_user=dict(type='str', no_log=True, removed_in_version="2.10"),
login_password=dict(type='str', no_log=True, removed_in_version="2.10"),
api_token=dict(type='str', no_log=True, aliases=["login_token"]),

2
lib/ansible/modules/source_control/gitlab_project.py
View file

@ -296,7 +296,7 @@ def deprecation_warning(module):
def main():
argument_spec = basic_auth_argument_spec()
argument_spec.update(dict(
server_url=dict(type='str', required=True, removed_in_version="2.10"),
server_url=dict(type='str', removed_in_version="2.10"),
login_user=dict(type='str', no_log=True, removed_in_version="2.10"),
login_password=dict(type='str', no_log=True, removed_in_version="2.10"),
api_token=dict(type='str', no_log=True, aliases=["login_token"]),