cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

win_iis_webapppool: stop any passwords from being returned (#33931)

Browse source
This commit is contained in:
Jordan Borean 2017-12-15 09:50:44 +10:00 committed by GitHub
parent cae14e16ac
commit 0ca828ebab
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/ansible/modules/windows/win_iis_webapppool.ps1
View file

@ -305,11 +305,13 @@ foreach ($element in $elements) {
foreach ($attribute in $attribute_collection) { foreach ($attribute in $attribute_collection) {
$attribute_name = $attribute.Name $attribute_name = $attribute.Name
if ($attribute_name -notlike "*password*") {
$attribute_value = $attribute_parent.$attribute_name $attribute_value = $attribute_parent.$attribute_name
$result.info.$element.Add($attribute_name, $attribute_value) $result.info.$element.Add($attribute_name, $attribute_value)
} }
} }
}
# Manually get the periodicRestart attributes in recycling # Manually get the periodicRestart attributes in recycling
foreach ($attribute in $pool.recycling.periodicRestart.Attributes) { foreach ($attribute in $pool.recycling.periodicRestart.Attributes) {

5
test/integration/targets/win_iis_webapppool/tasks/tests.yml
View file

@ -416,7 +416,7 @@
state: present state: present
attributes: attributes:
startMode: AlwaysRunning startMode: AlwaysRunning
processModel.identityType: 3 processModel.identityType: SpecificUser
processModel.userName: '{{ansible_user}}' processModel.userName: '{{ansible_user}}'
processModel.password: '{{ansible_password}}' processModel.password: '{{ansible_password}}'
register: iis_attributes_new_check register: iis_attributes_new_check
@ -434,7 +434,7 @@
state: present state: present
attributes: attributes:
startMode: AlwaysRunning startMode: AlwaysRunning
processModel.identityType: 3 processModel.identityType: SpecificUser
processModel.userName: '{{ansible_user}}' processModel.userName: '{{ansible_user}}'
processModel.password: '{{ansible_password}}' processModel.password: '{{ansible_password}}'
register: iis_attributes_new register: iis_attributes_new
@ -446,7 +446,6 @@
- iis_attributes_new.info.attributes.startMode == 'AlwaysRunning' - iis_attributes_new.info.attributes.startMode == 'AlwaysRunning'
- iis_attributes_new.info.processModel.identityType == 'SpecificUser' - iis_attributes_new.info.processModel.identityType == 'SpecificUser'
- iis_attributes_new.info.processModel.userName == ansible_user - iis_attributes_new.info.processModel.userName == ansible_user
- iis_attributes_new.info.processModel.password == ansible_password
- name: change attributes for newer IIS version again - name: change attributes for newer IIS version again
win_iis_webapppool: win_iis_webapppool: