cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Bring nxos_snmp_community in line

Browse source
This commit is contained in:
Nathaniel Case 2017-09-01 07:15:24 -04:00
parent 9e4cdd2fce
commit 0df77408d7
1 changed files with 9 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
lib/ansible/modules/network/nxos/nxos_snmp_community.py
View file

@ -32,6 +32,8 @@ description:
author: author:
- Jason Edelman (@jedelman8) - Jason Edelman (@jedelman8)
- Gabriele Gerbino (@GGabriele) - Gabriele Gerbino (@GGabriele)
notes:
- Tested against NXOSv 7.3.(0)D1(1) on VIRL
options: options:
community: community:
description: description:
@ -78,9 +80,7 @@ commands:
''' '''
import re from ansible.module_utils.nxos import load_config, run_commands
from ansible.module_utils.nxos import get_config, load_config, run_commands
from ansible.module_utils.nxos import nxos_argument_spec, check_args from ansible.module_utils.nxos import nxos_argument_spec, check_args
from ansible.module_utils.basic import AnsibleModule from ansible.module_utils.basic import AnsibleModule
@ -91,7 +91,7 @@ def execute_show_command(command, module):
'output': 'json', 'output': 'json',
} }
return run_commands(module, [command]) return run_commands(module, command)
def apply_key_map(key_map, table): def apply_key_map(key_map, table):
@ -117,9 +117,7 @@ def flatten_list(command_lists):
def get_snmp_groups(module): def get_snmp_groups(module):
command = 'show snmp group' data = execute_show_command('show snmp group', module)[0]
data = execute_show_command(command, module)[0]
group_list = [] group_list = []
try: try:
@ -127,14 +125,13 @@ def get_snmp_groups(module):
for group in group_table: for group in group_table:
group_list.append(group['role_name']) group_list.append(group['role_name'])
except (KeyError, AttributeError): except (KeyError, AttributeError):
return group_list pass
return group_list return group_list
def get_snmp_community(module, find_filter=None): def get_snmp_community(module, find_filter=None):
command = 'show snmp community' data = execute_show_command('show snmp community', module)[0]
data = execute_show_command(command, module)[0]
community_dict = {} community_dict = {}
@ -225,6 +222,7 @@ def main():
delta = dict(set(proposed.items()).difference(existing.items())) delta = dict(set(proposed.items()).difference(existing.items()))
commands = [] commands = []
if state == 'absent': if state == 'absent':
if existing: if existing:
command = "no snmp-server community {0}".format(community) command = "no snmp-server community {0}".format(community)
@ -239,6 +237,7 @@ def main():
results['changed'] = True results['changed'] = True
if not module.check_mode: if not module.check_mode:
load_config(module, cmds) load_config(module, cmds)
if 'configure' in cmds: if 'configure' in cmds:
cmds.pop(0) cmds.pop(0)
results['commands'] = cmds results['commands'] = cmds
@ -248,4 +247,3 @@ def main():
if __name__ == '__main__': if __name__ == '__main__':
main() main()