From 0e8eb1d17f9a5645d52bf5b7fc993530987c6eea Mon Sep 17 00:00:00 2001 From: Hannes Ljungberg Date: Thu, 18 Jul 2019 16:38:38 +0200 Subject: [PATCH] pip: Remove unused option use_mirrors and remove all ignore.txt entries PR #58977 * Remove unused option use_mirrors * Add changelog fragment --- changelogs/fragments/58977-pip-remove_use_mirrors.yml | 2 ++ lib/ansible/modules/packaging/language/pip.py | 1 - test/sanity/validate-modules/ignore.txt | 3 --- 3 files changed, 2 insertions(+), 4 deletions(-) create mode 100644 changelogs/fragments/58977-pip-remove_use_mirrors.yml diff --git a/changelogs/fragments/58977-pip-remove_use_mirrors.yml b/changelogs/fragments/58977-pip-remove_use_mirrors.yml new file mode 100644 index 00000000000..3b207b27e2b --- /dev/null +++ b/changelogs/fragments/58977-pip-remove_use_mirrors.yml @@ -0,0 +1,2 @@ +bugfixes: +- "pip - Remove the unused and undocumented option ``use_mirrors``." diff --git a/lib/ansible/modules/packaging/language/pip.py b/lib/ansible/modules/packaging/language/pip.py index 4dbf51a2bd8..2d365c0e287 100644 --- a/lib/ansible/modules/packaging/language/pip.py +++ b/lib/ansible/modules/packaging/language/pip.py @@ -587,7 +587,6 @@ def main(): virtualenv_site_packages=dict(type='bool', default=False), virtualenv_command=dict(type='path', default='virtualenv'), virtualenv_python=dict(type='str'), - use_mirrors=dict(type='bool', default=True), extra_args=dict(type='str'), editable=dict(type='bool', default=False), chdir=dict(type='path'), diff --git a/test/sanity/validate-modules/ignore.txt b/test/sanity/validate-modules/ignore.txt index edca52d0503..969db2e06a2 100644 --- a/test/sanity/validate-modules/ignore.txt +++ b/test/sanity/validate-modules/ignore.txt @@ -3029,9 +3029,6 @@ lib/ansible/modules/packaging/language/pear.py E322 lib/ansible/modules/packaging/language/pear.py E326 lib/ansible/modules/packaging/language/pear.py E337 lib/ansible/modules/packaging/language/pear.py E338 -lib/ansible/modules/packaging/language/pip.py E322 -lib/ansible/modules/packaging/language/pip.py E324 -lib/ansible/modules/packaging/language/pip.py E337 lib/ansible/modules/packaging/language/yarn.py E337 lib/ansible/modules/packaging/language/yarn.py E338 lib/ansible/modules/packaging/os/apk.py E326