cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Comment on is_executable's limitations and change logic to only use bit-manipulations

Browse source 
This is clearer to anyone who understands that unix file modes are bitfields.
This commit is contained in:
Toshio Kuratomi 2016-06-13 09:41:43 -07:00
parent facea1ff0c
commit 0e98ce11c4
1 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
lib/ansible/module_utils/basic.py
View file

@ -511,10 +511,17 @@ def heuristic_log_sanitize(data, no_log_values=None):
return output return output
def is_executable(path): def is_executable(path):
'''is the given path executable?''' '''is the given path executable?
return (stat.S_IXUSR & os.stat(path)[stat.ST_MODE]
or stat.S_IXGRP & os.stat(path)[stat.ST_MODE] Limitations:
or stat.S_IXOTH & os.stat(path)[stat.ST_MODE]) * Does not account for FSACLs.
* Most times we really want to know "Can the current user execute this
file" This function does not tell us that, only if an execute bit is set.
'''
# These are all bitfields so first bitwise-or all the permissions we're
# looking for, then bitwise-and with the file's mode to determine if any
# execute bits are set.
return ((stat.S_IXUSR | stat.S_IXGRP | stat.S_IXOTH) & os.stat(path)[stat.ST_MODE])
def _load_params(): def _load_params():
''' read the modules parameters and store them globally. ''' read the modules parameters and store them globally.