From 0fa556f75183238633396c7ab59bddd23c9a1931 Mon Sep 17 00:00:00 2001 From: Paul Belanger Date: Thu, 16 Jan 2020 08:22:51 -0500 Subject: [PATCH] Fix flake8 errors related to vyos.vyos collection (#66516) Signed-off-by: Paul Belanger --- lib/ansible/plugins/cliconf/vyos.py | 4 +--- test/units/modules/network/vyos/test_vyos_banner.py | 1 - test/units/modules/network/vyos/test_vyos_facts.py | 2 +- 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/lib/ansible/plugins/cliconf/vyos.py b/lib/ansible/plugins/cliconf/vyos.py index f0621508355..1b539d55ff4 100644 --- a/lib/ansible/plugins/cliconf/vyos.py +++ b/lib/ansible/plugins/cliconf/vyos.py @@ -33,12 +33,10 @@ version_added: "2.4" import re import json -from itertools import chain - from ansible.errors import AnsibleConnectionFailure from ansible.module_utils._text import to_text from ansible.module_utils.common._collections_compat import Mapping -from ansible.module_utils.network.common.config import NetworkConfig, dumps +from ansible.module_utils.network.common.config import NetworkConfig from ansible.module_utils.network.common.utils import to_list from ansible.plugins.cliconf import CliconfBase diff --git a/test/units/modules/network/vyos/test_vyos_banner.py b/test/units/modules/network/vyos/test_vyos_banner.py index 5837c5c5130..f9a172054c2 100644 --- a/test/units/modules/network/vyos/test_vyos_banner.py +++ b/test/units/modules/network/vyos/test_vyos_banner.py @@ -51,5 +51,4 @@ class TestVyosBannerModule(TestVyosModule): def test_vyos_banner_remove(self): set_module_args(dict(banner='pre-login', state='absent')) - commands = ['delete system login banner pre-login'] self.execute_module(changed=False, commands=[]) diff --git a/test/units/modules/network/vyos/test_vyos_facts.py b/test/units/modules/network/vyos/test_vyos_facts.py index a8320edf8d2..e7d525c2fac 100644 --- a/test/units/modules/network/vyos/test_vyos_facts.py +++ b/test/units/modules/network/vyos/test_vyos_facts.py @@ -94,4 +94,4 @@ class TestVyosFactsModule(TestVyosModule): def test_vyos_facts_invalid_subset(self): set_module_args(dict(gather_subset='cereal')) - result = self.execute_module(failed=True) + self.execute_module(failed=True)