From 13ce8728de747bdfbdd762319074ddd2510c539b Mon Sep 17 00:00:00 2001 From: James Tanner Date: Sat, 11 Jan 2014 11:02:01 -0500 Subject: [PATCH] Set accept_hostkey to False by default in the git module and fail early if the key is unknown --- source_control/git | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/source_control/git b/source_control/git index 320414a35cf..41cf53133d5 100644 --- a/source_control/git +++ b/source_control/git @@ -45,7 +45,7 @@ options: branch name, or a tag name. accept_hostkey: required: false - default: true + default: false version_added: "1.5" description: - Add the hostkey for the repo url if not already added. @@ -359,7 +359,7 @@ def main(): force=dict(default='yes', type='bool'), depth=dict(default=None, type='int'), update=dict(default='yes', type='bool'), - accept_hostkey=dict(default='yes', type='bool'), + accept_hostkey=dict(default='no', type='bool'), executable=dict(default=None), bare=dict(default='no', type='bool'), ), @@ -378,8 +378,8 @@ def main(): git_path = module.params['executable'] or module.get_bin_path('git', True) # add the git repo's hostkey - if module.params['accept_hostkey']: - add_git_host_key(module, repo, accept_hostkey=True) + #if module.params['accept_hostkey']: + add_git_host_key(module, repo, accept_hostkey=module.params['accept_hostkey']) if bare: gitconfig = os.path.join(dest, 'config')