cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

pvs args shall be submitted as a list

Browse source 
pvs args are submitted as a string to vgcreate, but the run_command
expects a list however. This caused problem for multiple args.
This commit is contained in:
Bekim Berisha 2014-09-29 22:48:58 +02:00
parent d2d0ed2259
commit 13ceb0255c
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
system/lvg.py
View file

@ -131,7 +131,6 @@ def main():
vgoptions = module.params['vg_options'].split() vgoptions = module.params['vg_options'].split()
if module.params['pvs']: if module.params['pvs']:
dev_string = ' '.join(module.params['pvs'])
dev_list = module.params['pvs'] dev_list = module.params['pvs']
elif state == 'present': elif state == 'present':
module.fail_json(msg="No physical volumes given.") module.fail_json(msg="No physical volumes given.")
@ -188,7 +187,7 @@ def main():
else: else:
module.fail_json(msg="Creating physical volume '%s' failed" % current_dev, rc=rc, err=err) module.fail_json(msg="Creating physical volume '%s' failed" % current_dev, rc=rc, err=err)
vgcreate_cmd = module.get_bin_path('vgcreate') vgcreate_cmd = module.get_bin_path('vgcreate')
rc,_,err = module.run_command([vgcreate_cmd] + vgoptions + ['-s', str(pesize), vg, dev_string]) rc,_,err = module.run_command([vgcreate_cmd] + vgoptions + ['-s', str(pesize), vg] + dev_list)
if rc == 0: if rc == 0:
changed = True changed = True
else: else: